Prepare XLA Bazel dependencies for enabling the layering check #34545
+4,413
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a bunch of XLA's third party dependencies compliant with Bazel's layering check by either: 1. disabling the layering check for the dependency's targets, or 2. Fix the build rules so that they comply with the layering check Both is either achieved by: 1. patching the packages 2. changing the BUILD files directly if we maintain Bazel BUILD files separately. Some of the patches can be upstreamed which I'm going to attempt separately. PiperOrigin-RevId: 837022746
copybara-service
bot
force-pushed
the
test_837022746
branch
from
37e8932 to
ec81051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare XLA Bazel dependencies for enabling the layering check
This makes a bunch of XLA's third party dependencies compliant with
Bazel's layering check by either:
Both is either achieved by:
Some of the patches can be upstreamed which I'm going to attempt separately.