PR #34520: [ROCm] Use rocminfo instead of lspci as it will report all connected gpus ev… #34550
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_837792013
branch
2 times, most recently
from
67f94bc to
32a337e
Compare
… connected gpus ev… Imported from GitHub PR #34520 …en inside docker container 📝 Summary of Changes Use rocminfo to detect number of gpus visible to xla 🎯 Justification lspci will report all the gpus connected to bus even inside the docker container with a limited visibility, hence the number of available gpus will be invalid for the tests synchonization 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix 📊 Benchmark (for Performance Improvements) Not relevant 🧪 Unit Tests: Not relevant 🧪 Execution Tests: Not relevant Copybara import of the project: -- bfd4a77 by Alexandros Theodoridis <[email protected]>: Use rocminfo instead of lspci as it will report all connected gpus even inside docker container -- ae08786 by Alexandros Theodoridis <[email protected]>: Use rocminfo from local_config_rocm -- bb21833 by Alexandros Theodoridis <[email protected]>: Trigger CI/CD pipeline -- b4e8784 by Alexandros Theodoridis <[email protected]>: Add missing rocminfo dependencies Merging this change closes #34520 FUTURE_COPYBARA_INTEGRATE_REVIEW=#34520 from ROCm:switch_parallel_gpu_execute_to_use_rocminfo b4e8784 PiperOrigin-RevId: 837792013
copybara-service
bot
force-pushed
the
test_837792013
branch
from
32a337e to
2ad561b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #34520: [ROCm] Use rocminfo instead of lspci as it will report all connected gpus ev…
Imported from GitHub PR #34520
…en inside docker container
📝 Summary of Changes
Use rocminfo to detect number of gpus visible to xla
🎯 Justification
lspci will report all the gpus connected to bus
even inside the docker container with a limited visibility,
hence the number of available gpus will be invalid for
the tests synchonization
🚀 Kind of Contribution
Please remove what does not apply: 🐛 Bug Fix
📊 Benchmark (for Performance Improvements)
Not relevant
🧪 Unit Tests:
Not relevant
🧪 Execution Tests:
Not relevant
Copybara import of the project:
--
bfd4a77 by Alexandros Theodoridis [email protected]:
Use rocminfo instead of lspci as it will report all connected gpus even inside docker container
--
ae08786 by Alexandros Theodoridis [email protected]:
Use rocminfo from local_config_rocm
--
bb21833 by Alexandros Theodoridis [email protected]:
Trigger CI/CD pipeline
--
b4e8784 by Alexandros Theodoridis [email protected]:
Add missing rocminfo dependencies
Merging this change closes #34520
FUTURE_COPYBARA_INTEGRATE_REVIEW=#34520 from ROCm:switch_parallel_gpu_execute_to_use_rocminfo b4e8784