Skip to content

Internal Cleanup. #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Internal Cleanup. #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/app/common/interfaces/data_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export type OpProfileProto = opProfileProto.Profile;
/** All overview page data table type. */
export type OverviewPageDataTable =
GeneralAnalysis|InputPipelineAnalysis|RecommendationResult|RunEnvironment|
SimpleDataTable|NormalizedAcceleratorPerformance;
SimpleDataTable|NormalizedAcceleratorPerformance|PodViewerTopology;

/** All overview page data tuple type. */
export type OverviewPageDataTuple = [
Expand All @@ -265,6 +265,7 @@ export type OverviewPageDataTuple = [
SimpleDataTable,
NormalizedAcceleratorPerformance,
SimpleDataTable,
PodViewerTopology,
];

/* tslint:disable enforce-name-casing */
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/overview_page/overview_page.ng.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
</smart-suggestion-view>
<ng-content select="[sblView]"></ng-content>
<ng-content select="[tfDataView]"></ng-content>
<ng-content select="[topology]"></ng-content>
</div>
</div>
</div>
6 changes: 3 additions & 3 deletions frontend/app/components/pod_viewer/topology_graph/topology_graph.ng.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<div class="mat-title">
{{deviceType}} {{xDimension}}x{{yDimension}}
</div>
<div class="topology-header">
<div class="control-row-left">
<div class="topology-header" *ngIf="(metricList && metricList.length) || (channelDb && channelDb.length)">
<div class="control-row-left" >
<span class="selected-metric-label control">{{selectedMetricLabel}}</span>
<button mat-icon-button [matMenuTriggerFor]="mecticMenu" aria-label="Metric menu">
<mat-icon>arrow_drop_down</mat-icon>
Expand Down Expand Up @@ -100,7 +100,7 @@
<pre>{{tooltipText}}</pre>
</div>

<div class="color-table">
<div class="color-table" *ngIf="podStatsPerCore">
<div
*ngFor="let colorInfo of colorInfos">
<div class="color-cell" [style.backgroundColor]="colorInfo.color"></div>
Expand Down
7 changes: 4 additions & 3 deletions frontend/app/components/pod_viewer/topology_graph/topology_graph.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

.container {
position: relative;
z-index: 0;
}

.label {
Expand All @@ -48,7 +49,7 @@
border-radius: 8px;
border: 1px solid #333;
background-color: #eee;
z-index:-2;
z-index: -2;
}

.node {
Expand All @@ -63,7 +64,7 @@

.node pre {
margin: 8px 0px 0px 2px;
font-size:13px;
font-size: 13px;
color: white;
}

Expand Down Expand Up @@ -94,7 +95,7 @@

.selected-metric-item {
font-weight: bold;
background: rgba(0, 0, 0, 0.02)
background: rgba(0, 0, 0, 0.02);
}

.channel-input {
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/components/pod_viewer/topology_graph/topology_graph.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ export class TopologyGraph implements OnChanges, OnDestroy {
private updateNodes() {
this.nodes = [];

if (!this.topology || !this.podStatsPerCore) {
if (!this.topology) {
return;
}

Expand All @@ -375,7 +375,7 @@ export class TopologyGraph implements OnChanges, OnDestroy {
this.nodes[chipz].nodes.push(nodeInfo);
}
});
} else {
} else if (this.podStatsPerCore) {
this.nodes[0] = {nodes: []};
Object.keys(this.podStatsPerCore).forEach(coreId => {
const podStatsRecord = this.podStatsPerCore![coreId];
Expand Down