Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add consistent hashing strategy for yurthub #2359

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tnsimon
Copy link
Contributor

@tnsimon tnsimon commented Mar 12, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature

What this PR does / why we need it:

Add consistent hashing strategy for yurt hub remote proxy load balancer strategy

Which issue(s) this PR fixes:

Fixes #2341

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

NONE

other Note

@tnsimon tnsimon requested a review from a team as a code owner March 12, 2025 05:37
Copy link

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 64.78873% with 50 lines in your changes missing coverage. Please review.

Project coverage is 42.41%. Comparing base (431558a) to head (ed21226).

Files with missing lines Patch % Lines
pkg/yurthub/proxy/remote/loadbalancer.go 70.49% 16 Missing and 2 partials ⚠️
cmd/yurthub/app/config/config.go 73.07% 14 Missing ⚠️
pkg/yurthub/proxy/proxy.go 0.00% 14 Missing ⚠️
pkg/yurthub/multiplexer/multiplexer.go 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2359      +/-   ##
==========================================
+ Coverage   42.30%   42.41%   +0.11%     
==========================================
  Files         394      394              
  Lines       26107    26204      +97     
==========================================
+ Hits        11044    11115      +71     
- Misses      14005    14029      +24     
- Partials     1058     1060       +2     
Flag Coverage Δ
unittests 42.41% <64.78%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]support consistent hashing strategy for load balancer.
1 participant