Skip to content

Spans are not sent to Zipkin sender when an error is thrown from a Sidekiq worker #172

@ghost

Description

When an error bubbles up from this line the trace spans are never flushed
https://github.com/openzipkin/zipkin-ruby/blob/master/lib/zipkin-tracer/sidekiq/middleware.rb#L31

This results in spans missing from the trace context in a Zipkin UI.

Was this behavior intentional?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions