Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amazon's EC2 Container Registry (ECR) to Relay #74

Open
christophermaier opened this issue Mar 31, 2017 · 2 comments
Open

Comments

@christophermaier
Copy link
Collaborator

From @christophermaier on December 30, 2016 19:25

Cog users wishing to access container images stored in Amazon's EC2 Container Registry from Relay will run into issues because a docker login yields a token that is effective for only 12 hours. With Relay's current implementation, you'd likely need to resort to things like restart the Relay process on a schedule in order for it to continue working.

Relay should have some smarts to contend with this use case. @kevsmith suggested exposing ECR support as a new engine within Relay.

Copied from original issue: operable/cog#1281

@christophermaier
Copy link
Collaborator Author

Peter Norton in Cog Slack mentioned https://github.com/awslabs/amazon-ecr-credential-helper. Perhaps adding support for a Docker credentials store could be a way to address this issue, and could be useful beyond just ECR.

@christophermaier
Copy link
Collaborator Author

From @pcn on February 9, 2017 23:1

This branch implements a limited functionality where only ECR can be used: https://github.com/pcn/go-relay/tree/how-would-this-work. The limitation with that is that any images that would be used need to be loaded into ECR. Requesting images that aren't in the provided ECR registry will result in a referrel to dockerhub being returned, and then trying to get from dockerhub will fail because the ECR creds will be preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants