Integration test

Signed-off-by: Attila Mészáros <[email protected]>

Author: csviri

docs/documentation/v5-0-migration.md

@@ -20,5 +20,9 @@ permalink: /docs/v5-0-migration
 3. Patching status through `UpdateControl` like the `patchStatus` method now by default
    uses Server Side Apply instead of simple patch. To use the former approach, use the feature flag 
    in [`ConfigurationService`](https://github.com/operator-framework/java-operator-sdk/blob/main/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java#L400-L400)
+   !!! IMPORTANT !!!
+   Migration from a non-SSA based controller to SSA based controller can cause problems, due to known issues. 
+   See the following [integration test](https://github.com/operator-framework/java-operator-sdk/blob/main/operator-framework/src/test/java/io/javaoperatorsdk/operator/StatusPatchSSAMigrationIT.java#L71-L82) where it is demonstrated.
+   Also, the related part of a [workaround](https://github.com/operator-framework/java-operator-sdk/blob/main/operator-framework/src/test/java/io/javaoperatorsdk/operator/StatusPatchSSAMigrationIT.java#L110-L116).
 4. `ManagedDependentResourceContext` has been renamed to `ManagedWorkflowAndDependentResourceContext` and is accessed
    via the accordingly renamed `managedWorkflowAndDependentResourceContext` method.

operator-framework/src/test/java/io/javaoperatorsdk/operator/StatusPatchSSAMigrationIT.java

@@ -45,8 +45,9 @@ void afterEach() {
     client.close();
   }
 
+
   @Test
-  void testMigratingFromNonSSAToSSA() {
+  void testMigratingToSSA() {
     var operator = startOperator(false);
     var testResource = client.resource(testResource()).create();
 
@@ -71,6 +72,49 @@ void testMigratingFromNonSSAToSSA() {
     actualResource.getSpec().setMessageInStatus(false);
     client.resource(actualResource).update();
 
+    await().untilAsserted(() -> {
+      var res = client.resource(testResource).get();
+      assertThat(res.getStatus()).isNotNull();
+      // !!! This is wrong, the message should be null,
+      // see issue in Kubernetes: https://github.com/kubernetes/kubernetes/issues/99003
+      assertThat(res.getStatus().getMessage()).isNotNull();
+      assertThat(res.getStatus().getValue()).isEqualTo(3);
+    });
+
+    client.resource(testResource()).delete();
+    operator.stop();
+  }
+
+  @Test
+  void workaroundMigratingFromToSSA() {
+    var operator = startOperator(false);
+    var testResource = client.resource(testResource()).create();
+
+    await().untilAsserted(() -> {
+      var res = client.resource(testResource).get();
+      assertThat(res.getStatus()).isNotNull();
+      assertThat(res.getStatus().getMessage()).isEqualTo(StatusPatchLockingReconciler.MESSAGE);
+      assertThat(res.getStatus().getValue()).isEqualTo(1);
+    });
+    operator.stop();
+
+    // start operator with SSA
+    operator = startOperator(true);
+    await().untilAsserted(() -> {
+      var res = client.resource(testResource).get();
+      assertThat(res.getStatus()).isNotNull();
+      assertThat(res.getStatus().getMessage()).isEqualTo(StatusPatchLockingReconciler.MESSAGE);
+      assertThat(res.getStatus().getValue()).isEqualTo(2);
+    });
+
+    var actualResource = client.resource(testResource()).get();
+    actualResource.getSpec().setMessageInStatus(false);
+    // removing the managed field entry for former method works
+    actualResource.getMetadata().setManagedFields(actualResource.getMetadata().getManagedFields()
+        .stream().filter(r -> !r.getOperation().equals("Update") && r.getSubresource() != null)
+        .toList());
+    client.resource(actualResource).update();
+
     await().untilAsserted(() -> {
       var res = client.resource(testResource).get();
       assertThat(res.getStatus()).isNotNull();
@@ -79,6 +123,7 @@ void testMigratingFromNonSSAToSSA() {
     });
 
     client.resource(testResource()).delete();
+    operator.stop();
   }