Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: e2e test to demonstrate namespace deletion problem fix #2528

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 6, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2024
@csviri csviri self-assigned this Sep 6, 2024
@csviri csviri changed the title Controller ns deletion feat: e2e test to demonstrate namespace deletion problem Sep 6, 2024
@csviri csviri force-pushed the controller-ns-deletion branch from 1d05db5 to f9b15cb Compare September 16, 2024 11:13
@csviri csviri linked an issue Sep 17, 2024 that may be closed by this pull request
@csviri csviri marked this pull request as ready for review September 17, 2024 09:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@csviri csviri requested a review from metacosm September 17, 2024 09:23
@csviri csviri changed the title feat: e2e test to demonstrate namespace deletion problem feat: e2e test to demonstrate namespace deletion problem fix Sep 17, 2024
sample-operators/controller-namespace-deletion/pom.xml Outdated Show resolved Hide resolved
}

private static boolean waitUntilResourcesDeleted() {
try (var client = new KubernetesClientBuilder().build()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we try to delay shutting down the informers and use them here instead of creating a new client?

Copy link
Collaborator Author

@csviri csviri Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a demonstration, of how the problems could be solved, thus without a change into to operator impl for now.
In a next iteration will come with a comprehensive solution. Note that to cover the whole cycle we need to delay of stop of reconciliation thus the whole operator so the finalizers are correctly removed.

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri force-pushed the controller-ns-deletion branch from 050b4c5 to 3077268 Compare September 20, 2024 07:08
@csviri csviri requested a review from metacosm September 20, 2024 07:10
@csviri csviri merged commit 1635c9e into next Sep 23, 2024
20 checks passed
@csviri csviri deleted the controller-ns-deletion branch September 23, 2024 09:08
metacosm pushed a commit that referenced this pull request Oct 10, 2024
metacosm pushed a commit that referenced this pull request Nov 5, 2024
metacosm pushed a commit that referenced this pull request Nov 6, 2024
csviri added a commit that referenced this pull request Nov 13, 2024
metacosm pushed a commit that referenced this pull request Nov 19, 2024
metacosm pushed a commit that referenced this pull request Nov 20, 2024
metacosm pushed a commit that referenced this pull request Nov 27, 2024
csviri added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful shutdown for controller's namespace deletion
3 participants