Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: mapping from annotation depends on type #2606

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Nov 22, 2024

No description provided.

Signed-off-by: Attila Mészáros <[email protected]>

compiles

Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri requested review from xstefank and adam-sandor and removed request for adam-sandor November 22, 2024 08:42
@csviri csviri linked an issue Nov 22, 2024 that may be closed by this pull request
@csviri csviri merged commit e86e295 into next Nov 27, 2024
57 checks passed
@csviri csviri deleted the type-for-annotation-mapping2 branch November 27, 2024 12:17
metacosm added a commit that referenced this pull request Nov 27, 2024
* improve: mapping from annotation depends on type

Signed-off-by: Attila Mészáros <[email protected]>

compiles

Signed-off-by: Attila Mészáros <[email protected]>

* refactor: avoid creating useless strings

Signed-off-by: Chris Laprun <[email protected]>

* refactor: ensure roundtrip works

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename toSimpleString to toGVKString for greater clarity

Signed-off-by: Chris Laprun <[email protected]>

* refactor: minor improvements

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
csviri added a commit that referenced this pull request Dec 6, 2024
* improve: mapping from annotation depends on type

Signed-off-by: Attila Mészáros <[email protected]>

compiles

Signed-off-by: Attila Mészáros <[email protected]>

* refactor: avoid creating useless strings

Signed-off-by: Chris Laprun <[email protected]>

* refactor: ensure roundtrip works

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename toSimpleString to toGVKString for greater clarity

Signed-off-by: Chris Laprun <[email protected]>

* refactor: minor improvements

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "OwnerType" Annotation for Non-GC'ed DependentResources
3 participants