Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus sample documentation and artifacts are not aligned with the Spring Boot sample project #169

Open
jareso-sidero opened this issue Oct 19, 2023 · 2 comments
Assignees

Comments

@jareso-sidero
Copy link

Hi guys,
I am noticing that the README.md in quarkus project just explains how to compile and execute the quarkus sample. I don't know Spring boot, but I found documentation and a yaml file not included in the Quarkus sample, that explains how to make the Spring boot sample work, the use case and the steps to test the sample.

Could this all be brought to Quarkus sample project?

@csviri
Copy link
Contributor

csviri commented Oct 23, 2023

Hi @jareso-sidero , will update the documentation, but might help to check the E2E tests:

https://github.com/operator-framework/josdk-webhooks/blob/0dd5c04085e1145c90bcf73a0fb943bf38bcb0e5/samples/quarkus/src/test/java/io/javaoperatorsdk/webhook/sample/QuarkusWebhooksE2E.java

That deploys the webhooks and tests them, you can also reproduce the same manually.

@jareso-sidero
Copy link
Author

jareso-sidero commented Oct 23, 2023 via email

@csviri csviri self-assigned this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants