Skip to content

feat: generalize container tool usage in Makefile template #6932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhuss
Copy link

@rhuss rhuss commented May 10, 2025

Description of the change:
This PR generalizes the container tool usage in the bundle build target to respect the CONTAINER_TOOL variable. The change replaces the hardcoded docker command with $(CONTAINER_TOOL) in the bundle-build target of the Makefile template, making it consistent with other container-related targets in the operator-sdk.

Motivation for the change:
Currently, the bundle build target hardcodes the use of docker as the container tool, which is inconsistent with other parts of the operator-sdk that respect the CONTAINER_TOOL variable. This change:

  1. Makes the bundle build process more flexible by allowing users to use alternative container tools like podman
  2. Maintains consistency with the rest of the operator-sdk tooling
  3. Follows the existing pattern used in other container-related targets

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested review from jberkhahn and oceanc80 May 10, 2025 09:21
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rhuss

Thank you for your contribution 🥇

I think that is OK because matches with the scaffold of kubebuilder: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/Makefile

However, you need to run make install and make generate locally to ensure that those files are properly updated in the testdata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants