[62577] Create a BorderBox::CollapsibleHeader component
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3a1eb7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HDinger
changed the title
BorderBox::CollapsibleHeader component
mrmir
force-pushed
the
feature/62577-create-a-collapsible-borderbox-component
branch
3 times, most recently
from
423341b to
3d42a7f
Compare
mrmir
force-pushed
the
feature/62577-create-a-collapsible-borderbox-component
branch
4 times, most recently
from
364dec0 to
d278433
Compare
mrmir
force-pushed
the
feature/62577-create-a-collapsible-borderbox-component
branch
from
d278433 to
18d5201
Compare
mrmir
force-pushed
the
feature/62577-create-a-collapsible-borderbox-component
branch
from
18d5201 to
0111e1d
Compare
HDinger
force-pushed
the
feature/62577-create-a-collapsible-borderbox-component
branch
from
edc5e5a to
c718605
Compare
|
HDinger
requested changes
Apr 1, 2025
app/components/primer/open_project/border_box/collapsible_header.rb
Outdated
Show resolved
Hide resolved
app/components/primer/open_project/border_box/collapsible_header.rb
Outdated
Show resolved
Hide resolved
app/components/primer/open_project/border_box/collapsible_header.rb
Outdated
Show resolved
Hide resolved
app/components/primer/open_project/border_box/collapsible_header.ts
Outdated
Show resolved
Hide resolved
app/components/primer/open_project/border_box/collapsible_header.ts
Outdated
Show resolved
Hide resolved
previews/primer/open_project/border_box/collapsible_header_preview.rb
Outdated
Show resolved
Hide resolved
previews/primer/open_project/border_box/collapsible_header_preview.rb
Outdated
Show resolved
Hide resolved
test/components/primer/open_project/border_box/collapsible_header_test.rb
Outdated
Show resolved
Hide resolved
test/components/primer/open_project/border_box/collapsible_header_test.rb
Outdated
Show resolved
Hide resolved
Comment on lines
30
to
53
| # @label Default | ||
| # @snapshot | ||
| def default | ||
| render_with_template | ||
| end | ||
|
|
||
| # @label With counter | ||
| # @snapshot | ||
| def with_count | ||
| render_with_template | ||
| end | ||
|
|
||
| # @label With description text | ||
| # @snapshot | ||
| def with_description | ||
| render_with_template | ||
| end | ||
|
|
||
| # @label Collapsed initially | ||
| # @snapshot | ||
| def collapsed | ||
| render_with_template | ||
| end | ||
| end |
There was a problem hiding this comment.
All of the template files that you added are basically the same. So either you provide different BorderBox examples in each or they should all use the same template with different variables, e.g
# @label Default
# @snapshot
def default
render_with_template(
template: "primer/open_project/border_box/collapsible_header_preview/playground",
locals: {
title: "Default title",
description: nil,
count: nil,
collapsed: false
}
)
end
There was a problem hiding this comment.
Makes sense, I redid them all with just the playground template
mrmir
force-pushed
the
feature/62577-create-a-collapsible-borderbox-component
branch
from
1af0473 to
2a79d0a
Compare
HDinger
approved these changes
Apr 2, 2025
HDinger
deleted the
feature/62577-create-a-collapsible-borderbox-component
branch
Merged
Thanks for all the education and help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Screenshots
Integration
List the issues that this change affects.
https://community.openproject.org/projects/design-system/work_packages/62577/activity
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist