Skip to content

Commit dafc33f

Browse files
authored
Merge pull request #161 from opsmill/develop
Pre-release
2 parents 1ca332a + 7162013 commit dafc33f

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

plugins/action/artifact_fetch.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,13 @@ def run(self, tmp: Any | None = None, task_vars: Any | None = None) -> dict:
8888
Display().v("Fetch Artifacts")
8989
result = client.fetch_single_artifact(filters=filters)
9090

91+
# Better error handling
92+
if not result:
93+
return {
94+
"failed": True,
95+
"msg": f"Unable to find '{artifact_name}' for '{target_id}'.",
96+
}
97+
9198
except Exception as exp:
9299
raise_from(AnsibleError(str(exp)), exp)
93100

plugins/action/query_graphql.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,9 @@ def run(self, tmp: Any | None = None, task_vars: Any | None = None) -> dict:
9090
branch=branch,
9191
timeout=timeout,
9292
validate_certs=validate_certs,
93+
display=Display(),
9394
)
94-
processor = InfrahubQueryProcessor(client=client)
95+
processor = InfrahubQueryProcessor(client=client, display=Display())
9596
Display().v("Processing Query")
9697
response = processor.fetch_and_process(query=graphql_query, variables=graph_variables)
9798
results["data"] = response

plugins/lookup/lookup.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@
9898
from ansible.errors import AnsibleError, AnsibleLookupError
9999
from ansible.module_utils.six import raise_from
100100
from ansible.plugins.lookup import LookupBase
101+
from ansible.utils.display import Display
101102
from ansible_collections.opsmill.infrahub.plugins.module_utils.infrahub_utils import (
102103
HAS_INFRAHUBCLIENT,
103104
InfrahubclientWrapper,
@@ -160,17 +161,17 @@ def run(
160161

161162
results = {}
162163
try:
163-
self.display().v("Initializing Infrahub Client")
164+
Display().v("Initializing Infrahub Client")
164165
client = InfrahubclientWrapper(
165166
api_endpoint=api_endpoint,
166167
token=token,
167168
branch=branch,
168169
timeout=timeout,
169170
validate_certs=validate_certs,
170-
display=self.display,
171+
display=Display(),
171172
)
172-
processor = InfrahubQueryProcessor(client=client, display=self.display)
173-
self.display().v("Processing Query")
173+
processor = InfrahubQueryProcessor(client=client, display=Display())
174+
Display().v("Processing Query")
174175
results = processor.fetch_and_process(query=graphql_query, variables=graph_variables)
175176

176177
except Exception as exc:

0 commit comments

Comments
 (0)