Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Change behavior of include to only include the requested fields #192

Open
dgarros opened this issue Dec 30, 2024 · 0 comments · May be fixed by #205
Open

task: Change behavior of include to only include the requested fields #192

dgarros opened this issue Dec 30, 2024 · 0 comments · May be fixed by #205
Labels
state/backlog This issue is part of the backlog type/task Body of work related to an epic

Comments

@dgarros
Copy link
Contributor

dgarros commented Dec 30, 2024

Component

Python SDK

Task Description

Currently it's possible to specify include and exclude when querying a node or a group of nodes from Infrahub.

Both methods are currently working on top of the default set of fields, meaning that

  • include can be used to add fields that are not included by default
  • exclude can be used to remove fields that are included by default

The issue with the current behavior is that the performance of a given query change over time if the schema changes and if more fields are being queried by default. there is no way to control that. this can be especially impacting if the queyr is also using prefetch_relationships

The proposal is to change the behavior of include to only include the fields that have been specified in include this way a query using include will be predictable and won't be impacted by future schema changes

@dgarros dgarros added the type/task Body of work related to an epic label Dec 30, 2024
@exalate-issue-sync exalate-issue-sync bot added state/need-triage This issue needs to be triaged state/needs-triage state/backlog This issue is part of the backlog and removed state/needs-triage state/need-triage This issue needs to be triaged labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/backlog This issue is part of the backlog type/task Body of work related to an epic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant