Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt JDK-8336768: Allow captureCallState and critical linker options to be combined #10305

Closed
wants to merge 1 commit into from

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Dec 13, 2024

Closes: #10304

Note

If merged, this should be backported to 24.2 as well

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 13, 2024
@zakkak zakkak marked this pull request as draft December 13, 2024 07:56
@zakkak zakkak force-pushed the 2024-12-13-fix-10304 branch from 7979a83 to 85bb1db Compare December 13, 2024 08:06
@zakkak zakkak requested a review from mur47x111 December 13, 2024 08:07
@zakkak zakkak marked this pull request as ready for review December 13, 2024 08:07
@mur47x111
Copy link
Member

mur47x111 commented Dec 13, 2024

I assume this needs to be backported to JDK24 (addition to GraalVM 24.2), right?
After a discussion with @fangerer , only backporting to GraalVM 24.2 is necessary

@mur47x111
Copy link
Member

Also could you please add a test case for us to notice this earlier? Thanks!

@fangerer
Copy link
Member

fyi: this PR is obsolete since #10301 is already merged.

@zakkak
Copy link
Collaborator Author

zakkak commented Dec 13, 2024

Also could you please add a test case for us to notice this earlier? Thanks!

I will have a look at it.

fyi: this PR is obsolete since #10301 is already merged.

The timing was interesting in this one :) Thank you

@zakkak zakkak closed this Dec 13, 2024
@zakkak zakkak deleted the 2024-12-13-fix-10304 branch December 13, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Native Image] JDK-8336768 breaks -H:+ForeignAPISupport
3 participants