Skip to content

Commit 5200752

Browse files
committed
[GR-72563] Normative: Remove minimal days from Intl Locale Info API.
1 parent 6761305 commit 5200752

File tree

4 files changed

+6
-12
lines changed

4 files changed

+6
-12
lines changed

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/intl/LocalePrototypeBuiltins.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2020, 2025, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2020, 2026, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0
@@ -673,13 +673,11 @@ private static TruffleString direction(JSLocaleObject localeObject) {
673673
public abstract static class JSLocaleGetWeekInfoNode extends JSBuiltinNode {
674674
@Child CreateDataPropertyNode createFirstDayNode;
675675
@Child CreateDataPropertyNode createWeekendNode;
676-
@Child CreateDataPropertyNode createMinimalDaysNode;
677676

678677
public JSLocaleGetWeekInfoNode(JSContext context, JSBuiltin builtin) {
679678
super(context, builtin);
680679
this.createFirstDayNode = CreateDataPropertyNode.create(context, IntlUtil.KEY_FIRST_DAY);
681680
this.createWeekendNode = CreateDataPropertyNode.create(context, IntlUtil.KEY_WEEKEND);
682-
this.createMinimalDaysNode = CreateDataPropertyNode.create(context, IntlUtil.KEY_MINIMAL_DAYS);
683681
}
684682

685683
@Specialization
@@ -694,7 +692,6 @@ public Object doLocale(JSLocaleObject localeObject,
694692
} else {
695693
firstDay = fw;
696694
}
697-
int minimalDays = weekData.minimalDaysInFirstWeek;
698695

699696
SimpleArrayList<Integer> weekendList = new SimpleArrayList<>(7);
700697
int weekendCease = weekData.weekendCease;
@@ -717,7 +714,6 @@ public Object doLocale(JSLocaleObject localeObject,
717714
JSObject weekInfo = JSOrdinary.create(context, realm);
718715
createFirstDayNode.executeVoid(weekInfo, firstDay);
719716
createWeekendNode.executeVoid(weekInfo, weekend);
720-
createMinimalDaysNode.executeVoid(weekInfo, minimalDays);
721717
return weekInfo;
722718
}
723719

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/util/IntlUtil.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2018, 2026, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* The Universal Permissive License (UPL), Version 1.0
@@ -194,7 +194,6 @@ private IntlUtil() {
194194
public static final String MILLISECONDS = "milliseconds";
195195
public static final String MILLISECONDS_DISPLAY = "millisecondsDisplay";
196196
public static final String MIN2 = "min2";
197-
public static final String MINIMAL_DAYS = "minimalDays";
198197
public static final String MINIMUM_FRACTION_DIGITS = "minimumFractionDigits";
199198
public static final String MINIMUM_INTEGER_DIGITS = "minimumIntegerDigits";
200199
public static final String MINIMUM_SIGNIFICANT_DIGITS = "minimumSignificantDigits";
@@ -319,7 +318,6 @@ private IntlUtil() {
319318
public static final TruffleString KEY_MICROSECONDS_DISPLAY = Strings.constant(MICROSECONDS_DISPLAY);
320319
public static final TruffleString KEY_MILLISECONDS = Strings.constant(MILLISECONDS);
321320
public static final TruffleString KEY_MILLISECONDS_DISPLAY = Strings.constant(MILLISECONDS_DISPLAY);
322-
public static final TruffleString KEY_MINIMAL_DAYS = Strings.constant(MINIMAL_DAYS);
323321
public static final TruffleString KEY_MINIMUM_FRACTION_DIGITS = Strings.constant(MINIMUM_FRACTION_DIGITS);
324322
public static final TruffleString KEY_MINIMUM_INTEGER_DIGITS = Strings.constant(MINIMUM_INTEGER_DIGITS);
325323
public static final TruffleString KEY_MINIMUM_SIGNIFICANT_DIGITS = Strings.constant(MINIMUM_SIGNIFICANT_DIGITS);

graal-js/test/test262.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2212,10 +2212,6 @@
22122212
"COMPILE_IMMEDIATELY" : "SKIP"
22132213
},
22142214
"comment" : "Long-running in compile mode"
2215-
}, {
2216-
"filePath" : "intl402/Locale/prototype/getWeekInfo/output-object-keys.js",
2217-
"status" : "FAIL",
2218-
"comment" : "new failures 2026-01-09"
22192215
}, {
22202216
"filePath" : "intl402/NumberFormat/prototype/format/format-significant-digits.js",
22212217
"status" : "PASS",

graal-js/test/testV8.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@
6161
}, {
6262
"filePath" : "intl/general/supported-locales-of.js",
6363
"status" : "FAIL"
64+
}, {
65+
"filePath" : "intl/locale/locale-info-check-return-types.js",
66+
"status" : "FAIL",
67+
"comment" : "Obsolete test: expects minimalDays in getWeekInfo()"
6468
}, {
6569
"filePath" : "intl/localematcher/bestfit-supplemental-files.js",
6670
"status" : "FAIL",

0 commit comments

Comments
 (0)