Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for exports in package.json #903

Open
sgammon opened this issue Mar 24, 2025 · 0 comments · May be fixed by #904
Open

Support for exports in package.json #903

sgammon opened this issue Mar 24, 2025 · 0 comments · May be fixed by #904

Comments

@sgammon
Copy link

sgammon commented Mar 24, 2025

Many packages, including react, use the exports property to define a formal module export surface.

However, GraalJs currently bails eagerly under such circumstances:

graaljs/graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/builtins/commonjs/NpmCompatibleESModuleLoader.java

Lines 427 to 430 in f256a80

PackageJson pjson = readPackageJson(packageUrl, env);
// 11.5 If pjson is not null and pjson.exports is not null or undefined, then
if (pjson != null && pjson.hasExportsProperty()) {
throw fail(UNSUPPORTED_PACKAGE_EXPORTS, packageSpecifier);

sgammon added a commit to elide-dev/graaljs that referenced this issue Mar 24, 2025
@sgammon
Add support for package.json exports field
6d4aa2b 
If a module `package.json` specifies `exports`, GraalJs will now read
them and prefer exports over standard resolution; export types can be
registered by the developer as preferred. In lieu of these types (and
as a default), the following export types are preferred, in order:

- `graaljs`
- `import` (in ESM)
- `require`
- `default`

Fixes and closes oracle#903

Relates-to: oracle#903
Signed-off-by: Sam Gammon <[email protected]>
sgammon added a commit to elide-dev/elide that referenced this issue Mar 24, 2025
@sgammon
feat(graalvm): add support for jsx/tsx
2ee5e1d 
feat: add precompiler ts/jsx/esm flags
feat: enable jsx/tsx support by default
feat: export node `stream` module facade
fix: polyfills for builtin node streams
fix: gvm `24.2.x` compat for graaljs
fix: support `package.json` exports in graaljs
chore: rebuild polyfills/js vfs

Applies patch to solve oracle/graaljs#903.

Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon mentioned this issue Mar 24, 2025
Merged
6 tasks
sgammon added a commit to elide-dev/elide that referenced this issue Mar 24, 2025
@sgammon
feat(graalvm): add support for jsx/tsx
8f07195 
feat: add precompiler ts/jsx/esm flags
feat: enable jsx/tsx support by default
feat: export node `stream` module facade
test: add smoke test for jsx/tsx
test: add smoke test for react imports
test: add smoke test for react rendering (ssr)
fix: polyfills for builtin node streams
fix: gvm `24.2.x` compat for graaljs
fix: support `package.json` exports in graaljs
chore: rebuild polyfills/js vfs
chore: update api pins
chore: update detekt baselines

Applies patch to solve oracle/graaljs#903.

Signed-off-by: Sam Gammon <[email protected]>
sgammon added a commit to elide-dev/elide that referenced this issue Mar 24, 2025
@sgammon
feat(graalvm): add support for jsx/tsx
c4859ae 
feat: add precompiler ts/jsx/esm flags
feat: enable jsx/tsx support by default
feat: export node `stream` module facade
test: add smoke test for jsx/tsx
test: add smoke test for react imports
test: add smoke test for react rendering (ssr)
fix: polyfills for builtin node streams
fix: gvm `24.2.x` compat for graaljs
fix: support `package.json` exports in graaljs
chore: rebuild polyfills/js vfs
chore: update api pins
chore: update detekt baselines

Applies patch to solve oracle/graaljs#903.

Signed-off-by: Sam Gammon <[email protected]>
sgammon added a commit to elide-dev/elide that referenced this issue Mar 24, 2025
@sgammon
feat(graalvm): add support for jsx/tsx
0e07ed7 
feat: add precompiler ts/jsx/esm flags
feat: enable jsx/tsx support by default
feat: export node `stream` module facade
test: add smoke test for jsx/tsx
test: add smoke test for react imports
test: add smoke test for react rendering (ssr)
fix: polyfills for builtin node streams
fix: gvm `24.2.x` compat for graaljs
fix: support `package.json` exports in graaljs
chore: rebuild polyfills/js vfs
chore: update api pins
chore: update detekt baselines

Applies patch to solve oracle/graaljs#903.

Signed-off-by: Sam Gammon <[email protected]>
sgammon added a commit to elide-dev/elide that referenced this issue Mar 24, 2025
@sgammon
feat(graalvm): add support for jsx/tsx
2f9f558 
feat: add precompiler ts/jsx/esm flags
feat: enable jsx/tsx support by default
feat: export node `stream` module facade
test: add smoke test for jsx/tsx
test: add smoke test for react imports
test: add smoke test for react rendering (ssr)
fix: polyfills for builtin node streams
fix: gvm `24.2.x` compat for graaljs
fix: support `package.json` exports in graaljs
chore: rebuild polyfills/js vfs
chore: update api pins
chore: update detekt baselines

Applies patch to solve oracle/graaljs#903.

Signed-off-by: Sam Gammon <[email protected]>
sgammon added a commit to elide-dev/elide that referenced this issue Mar 24, 2025
@sgammon
feat(graalvm): add support for jsx/tsx
8072d00 
feat: add precompiler ts/jsx/esm flags
feat: enable jsx/tsx support by default
feat: export node `stream` module facade
test: add smoke test for jsx/tsx
test: add smoke test for react imports
test: add smoke test for react rendering (ssr)
fix: polyfills for builtin node streams
fix: gvm `24.2.x` compat for graaljs
fix: support `package.json` exports in graaljs
chore: rebuild polyfills/js vfs
chore: update api pins
chore: update detekt baselines

Applies patch to solve oracle/graaljs#903.

Signed-off-by: Sam Gammon <[email protected]>
sgammon added a commit to elide-dev/elide that referenced this issue Mar 24, 2025
@sgammon
feat: add support for jsx/tsx (#1320)
1ccef2d 
feat(graalvm): add support for jsx/tsx

feat: add precompiler ts/jsx/esm flags
feat: enable jsx/tsx support by default
feat: export node `stream` module facade
test: add smoke test for jsx/tsx
test: add smoke test for react imports
test: add smoke test for react rendering (ssr)
fix: polyfills for builtin node streams
fix: gvm `24.2.x` compat for graaljs
fix: support `package.json` exports in graaljs
chore: rebuild polyfills/js vfs
chore: update api pins
chore: update detekt baselines

Applies patch to solve oracle/graaljs#903.

Signed-off-by: Sam Gammon <[email protected]>
sgammon added a commit to elide-dev/graaljs that referenced this issue Mar 24, 2025
@sgammon
Add support for package.json exports field
889800f 
If a module `package.json` specifies `exports`, GraalJs will now read
them and prefer exports over standard resolution; export types can be
registered by the developer as preferred. In lieu of these types (and
as a default), the following export types are preferred, in order:

- `graaljs`
- `import` (in ESM)
- `require`
- `default`

Fixes and closes oracle#903

Relates-to: oracle#903
Signed-off-by: Sam Gammon <[email protected]>
sgammon added a commit to elide-dev/graaljs that referenced this issue Mar 24, 2025
@sgammon
Add support for package.json exports field
2a9ea22 
If a module `package.json` specifies `exports`, GraalJs will now read
them and prefer exports over standard resolution; export types can be
registered by the developer as preferred. In lieu of these types (and
as a default), the following export types are preferred, in order:

- `graaljs`
- `import` (in ESM)
- `require`
- `default`

Fixes and closes oracle#903

Relates-to: oracle#903
Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon linked a pull request Mar 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for package.json exports field elide-dev/graaljs
1 participant
@sgammon