Fixed bug when calling Cursor.executemany() with all of the values in at

least one column being null followed by a second call where at least the
first row also has a null value but some of the later values are not
null (#291).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -41,6 +41,11 @@ Common Changes
 
 #)  Fixed regression with contents of :data:`Cursor.description` when calling
     :meth:`Cursor.parse()` with a query that returns LOBs.
+#)  Fixed bug when calling :meth:`Cursor.executemany()` with all of the values
+    in at least one column being null followed by a second call where at least
+    the first row also has a null value but some of the later values are not
+    null
+    (`issue 291 <https://github.com/oracle/python-oracledb/issues/291>`__).
 #)  Updated the `Jupyter notebook samples <https://github.com/oracle/
     python-oracledb/tree/main/samples/notebooks>`__ to cover recent
     python-oracledb features.

src/oracledb/impl/base/batch_load_manager.pyx

@@ -304,12 +304,13 @@ cdef class FullDataBatchLoadManager(BatchLoadManager):
         Goes to the next batch of data.
         """
         cdef:
-            bint defer_type_assignment = (self.offset == 0)
+            bint defer_type_assignment
             object row
             ssize_t i
         self._calculate_num_rows_in_batch(self.total_num_rows)
         if self.cursor_impl is not None:
             self.cursor_impl._reset_bind_vars(self.offset, self.num_rows)
+            defer_type_assignment = True
             for i in range(self.num_rows):
                 if i == self.num_rows - 1:
                     defer_type_assignment = False

src/oracledb/impl/base/bind_var.pyx

@@ -136,7 +136,7 @@ cdef class BindVar:
                 return self.var_impl._check_and_set_value(row_num, value, NULL)
             self.var_impl._check_and_set_value(row_num, value, &was_set)
             if was_set:
-                self.has_value = True
+                self.has_value = not defer_type_assignment
                 return 0
             self.var_impl = None
             self.var = None

tests/test_4000_cursor_executemany.py

@@ -27,6 +27,7 @@
 """
 
 import decimal
+import itertools
 
 import oracledb
 import pytest
@@ -475,7 +476,7 @@ def test_4030(cursor):
 
 @pytest.mark.parametrize("batch_size", [1, 5, 99, 199, 200])
 def test_4031(batch_size, conn, cursor, empty_tab, round_trip_checker):
-    "4030 - test executemany with various batch sizes"
+    "4031 - test executemany with various batch sizes"
     rows = [(i + 1, f"String for row {i + 1}") for i in range(200)]
     cursor.executemany(
         "insert into TestTempTable (IntCol, StringCol1) values (:1, :2)",
@@ -491,3 +492,37 @@ def test_4031(batch_size, conn, cursor, empty_tab, round_trip_checker):
         "select IntCol, StringCol1 from TestTempTable order by IntCol"
     )
     assert cursor.fetchall() == rows
+
+
+def test_4032(conn, cursor, empty_tab):
+    "4032 - test consecutive executemany() with all values null in first call"
+    rows = [(i + 1, None) for i in range(10)] + [
+        (i + 11, (i + 11) * 0.25) for i in range(10)
+    ]
+    for chunk in itertools.batched(rows, 4):
+        cursor.executemany(
+            "insert into TestTempTable (IntCol, NumberCol) values (:1, :2)",
+            list(chunk),
+        )
+    conn.commit()
+    cursor.execute(
+        "select IntCol, NumberCol from TestTempTable order by IntCol"
+    )
+    assert cursor.fetchall() == rows
+
+
+def test_4033(conn, cursor, empty_tab):
+    "4033 - test batched executemany() with all values null in first chunks"
+    rows = [(i + 1, None) for i in range(10)] + [
+        (i + 11, (i + 11) * 0.25) for i in range(10)
+    ]
+    cursor.executemany(
+        "insert into TestTempTable (IntCol, NumberCol) values (:1, :2)",
+        rows,
+        batch_size=4,
+    )
+    conn.commit()
+    cursor.execute(
+        "select IntCol, NumberCol from TestTempTable order by IntCol"
+    )
+    assert cursor.fetchall() == rows

tests/test_6100_cursor_executemany_async.py

@@ -27,6 +27,7 @@
 """
 
 import decimal
+import itertools
 
 import oracledb
 import pytest
@@ -436,3 +437,37 @@ async def test_6127(
         "select IntCol, StringCol1 from TestTempTable order by IntCol"
     )
     assert await async_cursor.fetchall() == rows
+
+
+async def test_6128(async_conn, async_cursor, empty_tab):
+    "6128 - test consecutive executemany() with all values null in first call"
+    rows = [(i + 1, None) for i in range(10)] + [
+        (i + 11, (i + 11) * 0.25) for i in range(10)
+    ]
+    for chunk in itertools.batched(rows, 4):
+        await async_cursor.executemany(
+            "insert into TestTempTable (IntCol, NumberCol) values (:1, :2)",
+            list(chunk),
+        )
+    await async_conn.commit()
+    await async_cursor.execute(
+        "select IntCol, NumberCol from TestTempTable order by IntCol"
+    )
+    assert await async_cursor.fetchall() == rows
+
+
+async def test_6129(async_conn, async_cursor, empty_tab):
+    "6129 - test batched executemany() with all values null in first chunks"
+    rows = [(i + 1, None) for i in range(10)] + [
+        (i + 11, (i + 11) * 0.25) for i in range(10)
+    ]
+    await async_cursor.executemany(
+        "insert into TestTempTable (IntCol, NumberCol) values (:1, :2)",
+        rows,
+        batch_size=4,
+    )
+    await async_conn.commit()
+    await async_cursor.execute(
+        "select IntCol, NumberCol from TestTempTable order by IntCol"
+    )
+    assert await async_cursor.fetchall() == rows