Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding separation when stats are maximally compressed #320

Open
dev-msp opened this issue Jul 1, 2023 · 1 comment
Open

Consider adding separation when stats are maximally compressed #320

dev-msp opened this issue Jul 1, 2023 · 1 comment

Comments

@dev-msp
Copy link

dev-msp commented Jul 1, 2023

image

There's a rather unfortunate coincidence where "min" is both the name of a stat and a stat unit, so that when the frame is resized small enough, it looks very much like the last value was N minutes vs ms. Seems the best fix would involve some 1-char separator between stats (|, maybe?), but no strong opinion.

@fxnn
Copy link

fxnn commented Nov 29, 2024

I want to add to this -- there are other issues with the numbers on small screens.

Screenshot 2024-11-29 at 11 36 06
  • There's a space between the keyword and its value, but no space between the value and the next keyword.
    • This violates the visual principle that things that belong together should also be grouped together in terms of spacing.
    • You might wonder, Is the avg now 11.333 or 3.579?
  • As OP already pointed out, the previous problem also leads to units and the following key collapsing.
    • Did the last sample take 1.882min (i.e. minutes)?
    • What does mmax mean?
    • And what is mjtr?
  • Often, the units are missing entirely, and it's hard to tell whether we're talking microseconds, milliseconds, seconds or even minutes.

In my mind:

  • there should always be a space between a value and the follow-up key,
  • there should always be a unit behind the number,
  • there should always be at least, say, 3 digits + decimal place per value; however,
  • the space between keyword and the following value is optional, and
  • if the screen gets too small to follow these rules, then the end of the line should simply be cut-off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants