[proposal] updates regarding the map projection (add scale_factor and remove map_origin.altitude) #5765
Closed
YamatoAndo
started this conversation in
Design
Replies: 2 comments
-
|
Pull Requests |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Merged! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I propose two updates regarding the map projection.
1. add
scale_factortomap_projector_info.yamlAllow the map scale factor to be specified arbitrarily.
For example, in Japan, maps are often created with a scale factor of 0.9999, enabling the selection of a scale factor suitable for the region.
However, in the MGRS and UTM coordinate systems, the scale factor is defined as 0.9996.
Additionally, since the Local coordinate system cannot be converted to latitude and longitude, the scale factor is not necessary.
Therefore, in practice, the scale factor is only applied when using the Transverse Mercator coordinate system.
The specific code changes are planned as follows:
modify
TransverseMercatorExact::UTM();in transverse_mercator_projector.cpp↓
If
scale_factoris not specified, I would like to handle the scale factor as 0.9996, the same as before.2. remove
map_origin.altitudefrommap_projector_info.yamlWe have previously allowed specifying altitude, but I plan to remove this.
Because the
vertical_datumparameter is set to accept values likeWGS84orEGM2008, the reference point for altitude is inherently determined, making it correct to always set the altitude to 0.0.Nevertheless, allowing altitude to be input may cause confusion about what value should be entered.
The specific code changes are planned as follows:
modify
msg.map_origin.altitude = data["map_origin"]["altitude"].as<double>();in map_projection_loader.cpp↓
So, even if
map_origin.altitudeis specified as before, it will always be treated as 0.0.※ Since
geographic_msgs/GeoPoint map_originwill remain unchanged, there will actually be no changes made to MapProjectorInfo.msgI plan to submit a Pull Request by early March.
Thank you for your support, and I look forward to your feedback!
Beta Was this translation helpful? Give feedback.
All reactions