Re-enable ECR?

[dukarc]

Hi Folks,

In our refarch kickoff we had commented out this code for ECR so we could progress with other setup steps... now that we are beyond these should we now enable it?

components:
  terraform:
    ecr:
      vars:
        enabled: true
        ecr_user_enabled: false
        enable_lifecycle_policy: true
        protected_tags: []
        image_tag_mutability: MUTABLE
        max_image_count: 500
        scan_images_on_push: true
        # github_actions_iam_role_enabled: false
        # github_actions_iam_role_attributes: [ "ecr" ]
        # github_actions_allowed_repos:
        #   - Vibrant-Planet/vbpt-infra
        #   - Vibrant-Planet/example-app-on-ecs
        #   - Vibrant-Planet/example-app-on-lambda-with-gha
        read_only_account_role_map:
          plat-dev: ["*"]
          plat-sandbox: ["*"]
          plat-staging: ["*"]
          plat-prod: ["*"]
        read_write_account_role_map:
          core-identity:
            - devops
            - developers
          core-auto:
            - admin
            - poweruser
        # ECR must be all lowercase
        images:
          - vibrant-planet/vbpt-infra
          - vibrant-planet/example-app-on-ecs
          - vibrant-planet/example-app-on-lambda-with-gha

[Benbentwo]

I'm assuming you're reffering to the subsection of code

        # github_actions_iam_role_enabled: false
        # github_actions_iam_role_attributes: [ "ecr" ]
        # github_actions_allowed_repos:
        #   - Vibrant-Planet/vbpt-infra
        #   - Vibrant-Planet/example-app-on-ecs
        #   - Vibrant-Planet/example-app-on-lambda-with-gha

That should be fine to re-enable. This assumes the mixins for ECR were vendored in - as those variables are defined there. I do remember we are moving those - so might need to update the mixins pointer.

If you run into an issue with local.enabled being duplicated just remove it from the mixin. We plan on fixing this in a new version and should be getting to it this week.

You also probably want github_actions_iam_role_enabled: true

[GabisCampana]

@dukarc Does Ben's reply above answer your question?

[dukarc]

that does ..thank you