Branch protection rules

[nikomatsakis]

The current rules seem to always require being overridden, even if there are approving reviews etc?

[youknowone]

The rule is all test passed + at least 1 (non-self) PR approve

[youknowone]

[yannham]

Then the protection has been blocking because of the mdbook lint failure? If that's the case, it's a temporary (broken) state, and I personally find the current policy reasonable, for what it's worth.

[nikomatsakis]

I agree this is a reasonable rule, but I thought I was seeing blocks even when a PR had been approved and was passing tests. Let's keep an eye on it.

[youknowone]

Before mdbook build is fixed, yes, that was one blocker.
Maybe it could be confused when we merged mdbook patch but didn't rebase other PRs yet.
Let me try to fix it if it happens again.

[youknowone]

I found I actually misconfigured it. I replaced "Lock branch" to "Restrict who can push", then now it seems working fine.