Skip to content

Rating DialogPrimitive.Close flickering #144

@trevorpfiz

Description

@trevorpfiz

I am noticing the DialogPrimitive.Close flickering when trying out the Rating example and when trying to build my own. I have noticed that adding a DialogFooter with styles sometimes fixes it? A weird bug.

https://www.loom.com/share/34ca439cf00947a48bebbb8d9ef8708f?sid=7cb8ce3d-624d-4f20-bcb8-f6518f85bc10

Activity

pasqualevitiello

pasqualevitiello commented on Dec 13, 2024

@pasqualevitiello
Contributor

Hey @trevorpfiz can you please provide more information (eg, OS, browser, etc)? Also, does that happens with all dialog components?

trevorpfiz

trevorpfiz commented on Dec 13, 2024

@trevorpfiz
Author

Hey @trevorpfiz can you please provide more information (eg, OS, browser, etc)? Also, does that happens with all dialog components?

macOS Sequoia 15.1.1. Using Chrome. I also see it in Arc. The bug doesn't seem to be there on Safari.

It is only the Rating dialog for some reason.

pasqualevitiello

pasqualevitiello commented on Dec 13, 2024

@pasqualevitiello
Contributor

Pretty weird, same OS here (Chrome 131.0.6778.110) but I cannot reproduce the issue: https://jumpshare.com/v/O0FpJIysOUIRyMv3lGO7

pasqualevitiello

pasqualevitiello commented on Dec 30, 2024

@pasqualevitiello
Contributor

Now I can see it (currently checking on Chrome 131.0.6778.205), but in a different component:

Screenshot 2024-12-30 at 13 37 47

If I remove margin top from the "+ Add another" or change the font size of that text, the close icon doesn't flicker anymore. Honestly, that does not make any sense to me. I think it's some weird issue with Chrome, since it seems to be working with other browsers.

pasqualevitiello

pasqualevitiello commented on Feb 25, 2025

@pasqualevitiello
Contributor

With the latest update the issue seems to have gone. Would you mind re-checking @trevorpfiz?

trevorpfiz

trevorpfiz commented on Feb 25, 2025

@trevorpfiz
Author

With the latest update the issue seems to have gone. Would you mind re-checking @trevorpfiz?

I still notice it on the Rating, Checkout, and Invite members components 🤷‍♂️

https://screen.studio/share/QSH8eGOm

pasqualevitiello

pasqualevitiello commented on Feb 25, 2025

@pasqualevitiello
Contributor

Can't reproduce in Chrome 133.0.6943.127 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @pasqualevitiello@trevorpfiz

        Issue actions

          Rating DialogPrimitive.Close flickering · Issue #144 · origin-space/originui