update sign cross-chain order types

orionprotocol · Jun 3, 2024 · ab4a674 · ab4a674
1 parent 517f127
commit ab4a674
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@orionprotocol/sdk",
-  "version": "0.22.0-rc16",
+  "version": "0.22.0-rc19",
   "description": "Orion Protocol SDK",
   "main": "./lib/index.cjs",
   "module": "./lib/index.js",

diff --git a/src/constants/orderTypes/orderTypes.ts b/src/constants/orderTypes/orderTypes.ts
@@ -20,7 +20,7 @@ export const CROSS_CHAIN_ORDER_TYPES = {
   Order: ORDER_TYPE,
   CrossChainOrder: [
     { name: 'limitOrder', type: 'Order' },
-    { name: 'chainId', type: 'uint24' },
+    { name: 'targetChainId', type: 'uint24' },
     { name: 'secretHash', type: 'bytes32' },
     { name: 'lockOrderExpiration', type: 'uint64' },
   ]

diff --git a/src/crypt/hashOrders/hashCrossChainOrder.ts b/src/crypt/hashOrders/hashCrossChainOrder.ts
@@ -4,9 +4,9 @@ import type { SupportedChainId, CrossChainOrder } from '../../types';
 const ORDER_TYPEHASH =
     '0xb5132db62dfceb466f2f8aee7a039db36a99772e5a9771d28388a5f9baad7c54';
 const CROSS_CHAIN_ORDER_TYPEHASH =
-    '0xc4666edeecc42a94cf6b87f39e1ca967792e6d738224365e54d7d06ec632b05c';
+    '0xb0edab98a08b4f5ce4f349d7cb1622bde999112acf1ac4a30cc9f394bd7809a6';
 
-export function getOrderHash(order: CrossChainOrder, chainId: SupportedChainId) {
+export function getOrderHash(order: CrossChainOrder, targetChainId: SupportedChainId) {
   const abiCoder = ethers.AbiCoder.defaultAbiCoder();
 
   // Generate the orderParamsHash
@@ -48,7 +48,7 @@ export function getOrderHash(order: CrossChainOrder, chainId: SupportedChainId)
       [
         CROSS_CHAIN_ORDER_TYPEHASH,
         limitOrderHash,
-        Number(chainId),
+        Number(targetChainId),
         order.secretHash,
         order.lockOrderExpiration,
       ]

diff --git a/src/crypt/signCrossChainOrder.ts b/src/crypt/signCrossChainOrder.ts
@@ -24,7 +24,7 @@ export type SignCrossChainOrderProps = {
   serviceFeeAssetAddress: string
   signer: ethers.Signer
   chainId: SupportedChainId
-  targetChainId?: SupportedChainId
+  targetChainId: SupportedChainId
 }
 
 export const signCrossChainOrder = async ({
@@ -76,7 +76,7 @@ export const signCrossChainOrder = async ({
 
   const crossChainOrder = {
     limitOrder: order,
-    chainId: Number(targetChainId),
+    targetChainId: Number(targetChainId),
     secretHash,
     lockOrderExpiration
   }
@@ -100,7 +100,7 @@ export const signCrossChainOrder = async ({
     targetChainId: Number(targetChainId),
     lockOrderExpiration
   }
-  const orderHash = getOrderHash(signedOrderWithoutId, chainId);
+  const orderHash = getOrderHash(signedOrderWithoutId, targetChainId);
 
   const signedCrossChainOrder: SignedCrossChainOrder = {
     ...signedOrderWithoutId,