Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages with status 503 and message temporarily_unavailable when revoking access and refresh tokens sequentially #709

Open
4 of 6 tasks
mih-kopylov opened this issue Oct 6, 2022 · 0 comments
Labels
bug Something is not working.

Comments

@mih-kopylov
Copy link

Preflight checklist

Describe the bug

When revoking access and refresh tokens sequentially, Hydra returns HTTP 200 status, but writes an error message to logs on the second call.

As I see, there're two issues here.

  1. There should be no error message. The case is not about an error at all, it's just a regular case. It looks more a debug level for me.
  2. The error message is totally opaque and therefore useless. The https://github.com/ory/fosite/blob/master/handler/oauth2/revocation.go#L89 gets two errors and produces one, hiding the original errors, so there's no way to figure out the root cause of the error. I would suggest keeping the context of the root errors when returning a new one.

Reproducing the bug

  • Authorize and get access_token and refresh_token pair
  • Call /oauth2/revoke with access_token
  • Call /oauth2/revoke with refresh_token
  • Note an error message in logs "error":{"debug":"","message":"temporarily_unavailable","reason":"","status":"Service Unavailable","status_code":503}

Relevant log output

"error":{"debug":"","message":"temporarily_unavailable","reason":"","status":"Service Unavailable","status_code":503}

Relevant configuration

No response

Version

oryd/hydra:v1.11.10

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Kubernetes

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant