New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should _winsorize preserve the equality S1+S2 = S1S2? It doesn't... #169

Open

MichaelTiemannOSC opened this issue Nov 30, 2022 · 0 comments

Labels

Contributor

MichaelTiemannOSC commented Nov 30, 2022

In the _winsorize function (data_warehouse.py):

# FIXME: If we have S1, S2, and S1S2 intensities, should we treat winsorized(S1)+winsorized(S2) as winsorized(S1S2)?                                                                            
# FIXME: If we have S1S2 (or S1 and S2) and S3 and S1S23 intensities, should we treat winsorized(S1S2)+winsorized(S3) as winsorized(S1S2S3)?

It's easy enough to fix if it should be fixed.

The text was updated successfully, but these errors were encountered:

MichaelTiemannOSC added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment