Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since file path separator "/" is used everywhere it might not work on WIN. #473

Open
KochynVolodymyr opened this issue Jun 20, 2022 · 8 comments
Assignees

Comments

@KochynVolodymyr
Copy link
Contributor

If search through the project "/" there are many entries. They are related to some paths. It might not work for the Window OS.

@KochynVolodymyr KochynVolodymyr changed the title Since file path separator "/" uses everywhere it might not work on WIN. Since file path separator "/" is used everywhere it might not work on WIN. Jun 20, 2022
@alain-rs
Copy link
Contributor

Use std::filesystem::path apath = "a" / "b" / "c" ; the / operator will create the right separator automatically.

@zaryabkhan-rs
Copy link
Contributor

@ravic-rs Checkout the summary of this issue on #632 (comment).

@zaryabkhan-rs
Copy link
Contributor

zaryabkhan-rs commented Oct 7, 2022

@ravic-rs IP configurator is not working properly in Windows build.
Screenshot windows FOEDAG build
image

  • It doesn't show the IPs.
  • When Generate IP is pressed then No folder/files are created in project Directory.

Expected Output:
Screenshot from Ubuntu FOEDAG Build
@ravic-rs
image

image

@ravic-rs
Copy link
Contributor

ravic-rs commented Oct 7, 2022

@ravic-rs IP configurator is not working properly in Windows build. Screenshot windows build image

  • It doesn't show the IPs.
  • When Generate IP is pressed then No folder/files are created in project Directory.

We don't have any IPs available other than the Mock ones, I will let @skyler-rs comment on it.

@zaryabkhan-rs
Copy link
Contributor

@ravic-rs IP configurator is not working properly in Windows build. Screenshot windows build image

  • It doesn't show the IPs.
  • When Generate IP is pressed then No folder/files are created in project Directory.

We don't have any IPs available other than the Mock ones, I will let @skyler-rs comment on it.

Yeah but we have two Mock Ips shows in ubuntu build. It also suppose to be shown in windows.

@ravic-rs
Copy link
Contributor

ravic-rs commented Oct 7, 2022

We won't be able to tell if this breaks until Windows build is supported.

@skyler-rs
Copy link
Contributor

@zaryabkhan-rs are there any errors printed in the tcl console? In particular, in foedag, which doesn't have a python venv installed, you should be seeing an error telling you a local python interpreter couldn't be found and then it printing what it found using LocateExecFile, but LocateExecFile fails on windows currently so my initial guess is this is failing at the finding python step, but can't be sure from that image.

It does look like the output Dir has a bad path display; however, i think i hardened the actual filepaths at the script execution point, but I can definitely look into fixing it earlier at this point as well.

I haven't tried a windows build recently, but as @ravic-rs mentions, eventually i'll probably need to build and debug this in windows so that could be a gating factor.

@alain-rs
Copy link
Contributor

alain-rs commented Oct 7, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants