Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Dynamic (discoverable) providers #707

Open
4 tasks
andersevenrud opened this issue Dec 31, 2018 · 3 comments
Open
4 tasks

[RFC] Dynamic (discoverable) providers #707

andersevenrud opened this issue Dec 31, 2018 · 3 comments
Assignees

Comments

@andersevenrud
Copy link
Member

andersevenrud commented Dec 31, 2018

At the moment packages (apps, themes, icons, sounds) can be discovered and automatically used by client/server via package:discover.

It would be cool if this could be added to service providers as well.

Basically use the same approach, except change package.json to (instead of package value):

{
  "osjs": {
    "type": "service"
  }
}

Then have the CLI generate a list (just like /packages.json from packages discovery) which is used by the index.js bootstrap script.

A downside with this is that you'd have to explicitly set all options in config.js - but that's not a big deal.

Maybe look into configuration publishing as well to prevent that.

  1. Add package.json entry
  2. Add new CLI task (service:discover)
  3. Update all official providers
  4. Update documentation
@andersevenrud andersevenrud self-assigned this Dec 31, 2018
@andersevenrud andersevenrud changed the title [v3] Dynamic (discoverable) providers Dynamic (discoverable) providers Feb 18, 2020
@17lwinn
Copy link

17lwinn commented Feb 22, 2020

Yep, would be better if i didn't have to build after installing providers

@andersevenrud
Copy link
Member Author

@17lwinn You'd still have to rebuild after adding a client service provider.

@17lwinn
Copy link

17lwinn commented Feb 22, 2020

I know but other providers should not require a rebuild

@andersevenrud andersevenrud changed the title Dynamic (discoverable) providers [RFC] Dynamic (discoverable) providers Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants