Add cyclotomic factorization #276
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 95.10% 94.97% -0.13%
==========================================
Files 13 14 +1
Lines 920 956 +36
==========================================
+ Hits 875 908 +33
- Misses 45 48 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fingolfin
reviewed
Mar 7, 2025
fingolfin
reviewed
Mar 7, 2025
fingolfin
reviewed
Mar 7, 2025
fingolfin
reviewed
Mar 7, 2025
fingolfin
reviewed
Mar 7, 2025
fingolfin
reviewed
Mar 7, 2025
lgoettgens
reviewed
Mar 7, 2025
|
I'd like to wait for Nemocas/AbstractAlgebra.jl#2058 to extend the factorization to universal polynomials. This is useful to factor the group order of non-simple generic character tables, i.e. tables containing generic cyclotomic numbers. |
|
@SoongNoonien AA v0.44.12 is out now |
SoongNoonien
force-pushed
the
cyc_fac
branch
2 times, most recently
from
ed2d186 to
0434f38
Compare
fingolfin
reviewed
Apr 30, 2025
lgoettgens
reviewed
Apr 30, 2025
Co-authored-by: Lars Göttgens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should replace thofma/Hecke.jl#1784. But if we merge this here we should also try to provide a method for multivariate/universal polynomials as these are also very common here.