Improve documentation of minimal_supercone_*
#4455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
changed the title
minimal_supercone_*
lgoettgens
added
the
topic: polyhedral geometry
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4455 +/- ##
==========================================
- Coverage 84.42% 84.42% -0.01%
==========================================
Files 668 668
Lines 88363 88363
==========================================
- Hits 74600 74599 -1
- Misses 13763 13764 +1
|
HereAround
reviewed
Jan 15, 2025
Comment on lines
-452
to
+460
| * `v` is in some maximal cone of `PF`. | ||
| * there exists a cone $\sigma$ in `PF` such that for every $i$, if the | ||
| $i$-th entry of $v$ is positive, then the $i$-th ray of `PF` belongs | ||
| to $\sigma$. |
Member
There was a problem hiding this comment.
I am not sure if I see how these two are equivalent.
Collaborator
Author
There was a problem hiding this comment.
They are not! The previous docstring was not correct.
HereAround
approved these changes
Jan 17, 2025
aaruni96
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.