Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Base.deepcopy_internal for Group interface #860

Closed
thofma opened this issue Dec 3, 2021 · 4 comments
Closed

Missing Base.deepcopy_internal for Group interface #860

thofma opened this issue Dec 3, 2021 · 4 comments
Assignees

Comments

@thofma
Copy link
Collaborator

thofma commented Dec 3, 2021

Was doing some computations and encountered:

ERROR: Missing method from Group interface: `Base.deepcopy_internal(::PcGroupElem, ::IdDict)`
Stacktrace:
[...]
@fingolfin fingolfin changed the title Missing method from Group interface Missing Base.deepcopy_internal for Group interface Feb 1, 2022
@fingolfin
Copy link
Member

Related: oscar-system/GAP.jl#197

@ThomasBreuer
Copy link
Member

How to reproduce the problem:
deepcopy([one(small_group(2, 1))])

@fingolfin
Copy link
Member

Full backtrace:

julia> deepcopy([one(small_group(2, 1))])
ERROR: Missing method from Group interface: `Base.deepcopy_internal(::PcGroupElem, ::IdDict)`
Stacktrace:
 [1] deepcopy_internal(g::PcGroupElem, stackdict::IdDict{Any, Any})
   @ GroupsCore ~/.julia/packages/GroupsCore/63Vm8/src/group_elements.jl:30
 [2] _deepcopy_array_t(x::Array, T::Type, stackdict::IdDict{Any, Any})
   @ Base ./deepcopy.jl:105
 [3] deepcopy_internal
   @ ./deepcopy.jl:92 [inlined]
 [4] deepcopy(x::Vector{PcGroupElem})
   @ Base ./deepcopy.jl:26
 [5] top-level scope
   @ REPL[2]:1

So GroupsCore forces us to be nice and implement the interface properly :-). OK, so we just have to do that. @ThomasBreuer will work on it.

@fingolfin
Copy link
Member

Resolved by #1037

bschroter pushed a commit to bschroter/oscar-matroids that referenced this issue Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants