Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meeting pages: improve top nav bar #227

Closed
fingolfin opened this issue Apr 8, 2022 · 5 comments · Fixed by #377
Closed

Meeting pages: improve top nav bar #227

fingolfin opened this issue Apr 8, 2022 · 5 comments · Fixed by #377
Labels
enhancement New feature or request

Comments

@fingolfin
Copy link
Member

On meeting pages like https://oscar.computeralgebra.de/meetings/2022-02/ we should a nav bar at the top for the various subpages. This could be improved in various ways:

  • highlight the currently active page
  • render it nicer
  • allow for an order other than alphabetical (?)
@fingolfin fingolfin added the enhancement New feature or request label Apr 8, 2022
aaruni96 added a commit to aaruni96/oscar-website that referenced this issue Oct 23, 2024
aaruni96 added a commit to aaruni96/oscar-website that referenced this issue Oct 25, 2024
aaruni96 added a commit to aaruni96/oscar-website that referenced this issue Oct 25, 2024
fingolfin pushed a commit that referenced this issue Oct 25, 2024
@fingolfin fingolfin reopened this Oct 25, 2024
@fingolfin
Copy link
Member Author

First work was done in PR #377 but some tweaking would be good; see also the comment I left there

@aaruni96
Copy link
Member

From @fingolfin :

So it looks like this now for me: Screen Shot 2024-10-25 at 14 38 50

Some remarks: instead of an "aqua" box to highlight current selection, perhaps simply change it to bold face?

And the gray next to gray isn't too nice. Maybe try orange, e.g. #fab914 and then change the link color in the top bar only from blue to black?

@aaruni96
Copy link
Member

Does this look any better, @fingolfin ? We tried #fab914, but it looked too bright/shiny/harsh/in-your-face (@HereAround and I can't agree on the right word). We also tried the "oscar yellow" from the text "symbolic tools" in the oscar logo, but didn't like it.

The blue is #a9ddf7

image

@fingolfin
Copy link
Member Author

Thank you it is much better now. Some remaining requests:

  1. when I am on the landing page for a meeting, nothing is highlighted (bold) in the "subnavigation". Perhaps the title of the meeting should be bold then? Or perhaps the landing page could be represented in the list of subpages (e.g. first item "Overview" or so)
  2. there is more vertical white space above the headline "OSCAR workshop" on the landing page than on e.g. the "Participants" page (see Aaruni's screenshot in the preceding comment). This is IMHO better, resp. on "Participants" (and the other subpages) there is too little vertical white space there.
  3. In addition I would reduce the vertical blue space below the subnav a bit (say from padding-bottom: 40px to 20px. Then it looks better balanced to me.

@fingolfin
Copy link
Member Author

I am very happy with this now. Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants