Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cosmrs from osmosis-test-tube and only relying osmosis-std types #25

Open
iboss-ptk opened this issue Jun 15, 2023 · 0 comments
Open

Comments

@iboss-ptk
Copy link
Collaborator

iboss-ptk commented Jun 15, 2023

Reason being, cosmrs types don't derive serde and osmosis-std now have ability to generate types from cosmos module.

potential blocker: osmosis-labs/osmosis-rust#52

Problem

  • osmosis-std struct requires implementing Serialize & Deserialize but tendermint_proto's structs do not implement them, so whenever there is a struct that depends on tendermint_proto, it will cause compile errors
  • it maps tendermint related struct to tendermint_proto by this line
  • This hack is used to skip struct that depends on tendermint_proto to suppress compiles error.

So that maybe not all of them can be replaced at the moment, only case by case, unless the blocker is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant