Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid the creation of duplicate project / packages IDs #9417

Open
sschuberth opened this issue Nov 12, 2024 · 0 comments
Open

Avoid the creation of duplicate project / packages IDs #9417

sschuberth opened this issue Nov 12, 2024 · 0 comments
Labels
analyzer About the analyzer tool enhancement Issues that are considered to be enhancements

Comments

@sschuberth
Copy link
Member

ORT uses the same Identifier class for both projects and packages. Under certain conditions, the analyzer's logic might infer the same ID for project / packages, causing a clash which makes the AnalyzerResultBuilder class create an error.

There are different root causes for duplicate IDs, which each probably require a dedicated solution to avoid duplicates.

Possible causes for project vs package duplicates:

  • The same "thing" could be seen as both a dependency and a project in a (mono-)repo that has project A with dependency package B, but the source code of B is hosted in the same repo.

Possible causes for package vs package duplicates:

  • E.g. NPM and Yarn projects could depend on the same (?) package, but it gets pulled from different (private) registries.

Possible causes for project vs project duplicates:

  • A repository contains multiple template projects that use the same properties (e.g. here and here).
  • ORT's logic to come up with project names for projects without (enough) metadata (like Python's requirements.txt files) could create name / id clashes.
@sschuberth sschuberth added analyzer About the analyzer tool enhancement Issues that are considered to be enhancements labels Nov 12, 2024
@sschuberth sschuberth mentioned this issue Nov 12, 2024
Closed
@sschuberth sschuberth mentioned this issue Nov 27, 2024
Merged
@sschuberth sschuberth mentioned this issue Dec 12, 2024
Open
@cz-dev-ge cz-dev-ge mentioned this issue Jan 14, 2025
Open
sschuberth added a commit that referenced this issue Jan 20, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
fc935f7 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

This change deliberately does not change expected results for tests yet,
even if that makes this commit on its own not pass tests, to
semantically split out that bigger change in to separate commit.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 20, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
fb004bc 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

This change deliberately does not change expected results for tests yet,
even if that makes this commit on its own not pass tests, to
semantically split out that bigger change in to separate commit.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 20, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
097e72e 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

This change deliberately does not change expected results for tests yet,
even if that makes this commit on its own not pass tests, to
semantically split out that bigger change in to separate commit.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 20, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
24e87cd 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 20, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
3d9f984 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 20, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
6ef9963 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 20, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
f54fadf 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 20, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
e05cd2d 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 20, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
584cccd 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 21, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
2a6f2fe 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 21, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
9f81699 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 21, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
be33216 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth added a commit that referenced this issue Jan 21, 2025
@sschuberth
fix(analyzer)!: Suffix project types with "Project"
b4e5868 
In relation to #9417, this avoids duplicate project vs. package IDs by
adding a "Project" suffix to the `type` of project IDs.

This change breaks existing package configurations that refer to
project IDs. The fix it to simply add the "Project" suffix to the type
as part of the project ID in the package configurations as well.

Signed-off-by: Sebastian Schuberth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer About the analyzer tool enhancement Issues that are considered to be enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sschuberth