Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit+Modal related: MOUNT_DIR not syncing local folder with volume #241

Open
zablit opened this issue Jan 21, 2025 · 1 comment
Open

Comments

@zablit
Copy link

zablit commented Jan 21, 2025

This is for bugs only

Did you already ask in the discord?

Yes

You verified that this is a bug and not a feature request or question by asking in the discord?

Yes

Describe the bug

MOUNT_DIR doesn't sync the Modal volume with the local assigned folder even though the names match. Local folder remains empty. Any idea what i might be doing wrong? Thanks!

The relevant lines of code in run_modal.py are:

(lines 28-29)
MOUNT_DIR = "/root/ai-toolkit/outputs" # due to "cannot mount volume on non-empty path" requirement

(lines 95-96)
# create the Modal app with the necessary mounts and volumes app = modal.App(name="headshots", image=image, mounts=[code_mount], volumes={MOUNT_DIR: model_volume})

(lines 141-143)
job.config['process'][0]['training_folder'] = MOUNT_DIR os.makedirs(MOUNT_DIR, exist_ok=True) print(f"Training outputs will be saved to: {MOUNT_DIR}")

and in the ai-toolkit config yaml (line 9):

training_folder: "/root/ai-toolkit/outputs" # must match MOUNT_DIR from run_modal.py

@vivek-kumar-poddar
Copy link

I am having the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants