Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not include NoGames matches in tournament NotEnoughVerifiedMatches threshold #592

Open
1 task
hburn7 opened this issue Feb 7, 2025 · 1 comment · May be fixed by #610
Open
1 task

Do not include NoGames matches in tournament NotEnoughVerifiedMatches threshold #592

hburn7 opened this issue Feb 7, 2025 · 1 comment · May be fixed by #610
Labels
area:processing area:tournaments bug A confirmed or reported event of unexpected behavior good first issue Denotes something that is easy to implement and would make for a good initial contribution. project:DataWorkerService Items related to the DataWorkerService project

Comments

@hburn7
Copy link
Collaborator

hburn7 commented Feb 7, 2025 •
edited
Loading

We have a rule which pre-rejects tournaments which have 20%+ rejected matches. If a match has the NoGames rejection reason (and no other rejection reason), it should be excluded from this calculation.

  • In MatchGameCountCheck, update the logic to exclude matches with NoGames from the count of valid games.
@hburn7 hburn7 added area:processing area:tournaments bug A confirmed or reported event of unexpected behavior project:DataWorkerService Items related to the DataWorkerService project good first issue Denotes something that is easy to implement and would make for a good initial contribution. labels Feb 7, 2025
@hburn7 hburn7 moved this to Ready in otr-beta-v2 Feb 21, 2025
@majorro
Copy link
Contributor

majorro commented Feb 22, 2025

taking this

@majorro majorro linked a pull request Feb 22, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:processing area:tournaments bug A confirmed or reported event of unexpected behavior good first issue Denotes something that is easy to implement and would make for a good initial contribution. project:DataWorkerService Items related to the DataWorkerService project
Projects
otr-beta-v2
Status: Ready
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude empty matches from tournaments threshold calculation in checks majorro/otr-api
2 participants
@majorro @hburn7