Skip to content

Commit 4d19ec7

Browse files
regisbarbrandes
authored andcommitted
fix: auto-build images in nightly
MFE images were not automatically built in nightly: this occurred both in local and dev mode. Close #157
1 parent 455bd21 commit 4d19ec7

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tutormfe/plugin.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,12 +207,12 @@ def _print_mfe_public_hosts(
207207
def _build_3rd_party_dev_mfes_on_launch(
208208
image_names: list[str], context_name: t.Literal["local", "dev"]
209209
) -> list[str]:
210-
if context_name == "dev":
211-
for mfe_name, _mfe_attrs in iter_mfes():
212-
if mfe_name not in CORE_MFE_APPS:
213-
# We don't require to build core MFEs because images are available from
214-
# the public registry.
215-
image_names.append(f"{mfe_name}-dev")
210+
for mfe_name, _mfe_attrs in iter_mfes():
211+
if __version_suffix__ or (context_name == "dev" and mfe_name not in CORE_MFE_APPS):
212+
# We build MFE images:
213+
# - in nightly
214+
# - in development for non-core apps
215+
image_names.append(f"{mfe_name}-dev")
216216
return image_names
217217

218218

0 commit comments

Comments
 (0)