Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the Course-Authoring MFE throws an error during env rendering #189

Closed
Danyal-Faheem opened this issue Feb 13, 2024 · 0 comments · Fixed by #190
Closed

Removing the Course-Authoring MFE throws an error during env rendering #189

Danyal-Faheem opened this issue Feb 13, 2024 · 0 comments · Fixed by #190
Assignees
Labels
bug Something isn't working

Comments

@Danyal-Faheem
Copy link
Contributor

When you remove the course-authoring mfe using the method defined here and then run tutor config save, it throws an error. The error is:

Error rendering patch 'openedx-cms-development-settings':
# MFE-specific settings
COURSE_AUTHORING_MICROFRONTEND_URL = "http://{{ MFE_HOST }}:{{ get_mfe('course-authoring')["port"] }}/course-authoring"
CORS_ORIGIN_WHITELIST.append("http://{{ MFE_HOST }}:{{ get_mfe('course-authoring')["port"] }}")
LOGIN_REDIRECT_WHITELIST.append("{{ MFE_HOST }}:{{ get_mfe('course-authoring')["port"] }}")
CSRF_TRUSTED_ORIGINS.append("{{ MFE_HOST }}:{{ get_mfe('course-authoring')["port"] }}")

Error rendering template apps/openedx/settings/cms/development.py
Error: Missing configuration value: 'dict object' has no attribute 'port'

This error is likely due to not having a condition in place in the openedx-cms-development-settings patch.

@Danyal-Faheem Danyal-Faheem self-assigned this Feb 13, 2024
@Danyal-Faheem Danyal-Faheem changed the title Removing Course-Authoring throws an error Removing the Course-Authoring MFE throws an error Feb 13, 2024
@Danyal-Faheem Danyal-Faheem moved this from Pending Triage to In review in Tutor project management Feb 13, 2024
@Danyal-Faheem Danyal-Faheem added the bug Something isn't working label Feb 13, 2024
@regisb regisb changed the title Removing the Course-Authoring MFE throws an error Removing the Course-Authoring MFE throws an error during env rendering Feb 13, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Tutor project management Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant