-
Notifications
You must be signed in to change notification settings - Fork 12
Description
Summary of request
Continuing the effort to remove project specific references...
There are 3 different profiles that are used in an unclear way to indicate that the server is running with an S3 compatible backend. Those profiles are:
collaboratory
amazon
aws
We want to simplify the Score Server code base and operation to use the single profile s3
instead.
s3
is chosen instead of amazon
or aws
since the Score server is compatible with any S3 API, such as minio or Ceph, in addition to the Amazon AWS service.
This work will replace references to these profiles in @Profile
annotations within java files, and replace their sections in the application.yaml
default config.
Details
In the following classes, update the @Profile
annotations to remove the profile names collaboratory
, amazon
, and aws
and replace then with s3
:
- BackendHealth
- ServerConfig
- S3Config
- S3DownloadService
- S3ListingService
- S3UploadService
In the server application.yaml
:
- Remove the sections for
amazon
andcollaboratory
- Add a new section for the profile
s3
.- Include every property that could be provided to configure our
s3
connection (refer toS3Config
class) - Comment out any properties that should not have a default (url, encryption key, etc.)
- Include every property that could be provided to configure our
Add some documentation to the score-server/README.md:
- Section for S3
- name the spring profile required
- list the configuration properties and what they do
Additional context
With these changes, we will need to update any documentation we have on score profiles, including overture.bio .