Test unzipExecutable

Author: owenthereal

commands/updater.go

@@ -40,15 +40,6 @@ func (updater *Updater) timeToUpdate() bool {
 	return writeTime(updateTimestampPath, time.Now().Add(wait))
 }
 
-func (updater *Updater) latestReleaseNameAndVersion() (name, version string) {
-	// Create Client with a stub Credentials
-	c := github.Client{Credentials: &github.Credentials{Host: updater.Host}}
-	name, _ = c.GhLatestTagName()
-	version = strings.TrimPrefix(name, "v")
-
-	return
-}
-
 func (updater *Updater) PromptForUpdate() (err error) {
 	if !updater.timeToUpdate() {
 		return
@@ -91,6 +82,15 @@ func (updater *Updater) Update() (err error) {
 	return
 }
 
+func (updater *Updater) latestReleaseNameAndVersion() (name, version string) {
+	// Create Client with a stub Credentials
+	c := github.Client{Credentials: &github.Credentials{Host: updater.Host}}
+	name, _ = c.GhLatestTagName()
+	version = strings.TrimPrefix(name, "v")
+
+	return
+}
+
 func (updater *Updater) updateTo(releaseName, version string) (err error) {
 	fmt.Printf("Updating gh to %s...\n", version)
 	downloadURL := fmt.Sprintf("https://%s/jingweno/gh/releases/download/%s/gh_%s_%s_%s.zip", updater.Host, releaseName, version, runtime.GOOS, runtime.GOARCH)

commands/updater_test.go

@@ -3,9 +3,11 @@ package commands
 import (
 	"fmt"
 	"github.com/bmizerany/assert"
+	"io"
 	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
+	"os"
 	"path/filepath"
 	"testing"
 )
@@ -28,3 +30,18 @@ func TestUpdater_downloadFile(t *testing.T) {
 	assert.Equal(t, "1234", string(content))
 	assert.Equal(t, "gh.zip", filepath.Base(path))
 }
+
+func TestUpdater_unzipExecutable(t *testing.T) {
+	target, _ := ioutil.TempFile("", "unzip-test")
+	defer target.Close()
+
+	source, _ := os.Open(filepath.Join("..", "fixtures", "gh.zip"))
+	defer source.Close()
+
+	_, err := io.Copy(target, source)
+	assert.Equal(t, nil, err)
+
+	exec, err := unzipExecutable(target.Name())
+	assert.Equal(t, nil, err)
+	assert.Equal(t, "gh", filepath.Base(exec))
+}