Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New emoji picker is not showing the custom emoji #4010

Closed
gabek opened this issue Nov 11, 2024 · 7 comments
Closed

New emoji picker is not showing the custom emoji #4010

gabek opened this issue Nov 11, 2024 · 7 comments
Labels
bug Something isn't working chat Issues dealing with the web chat client and server

Comments

@gabek
Copy link
Member

gabek commented Nov 11, 2024

Share your bug report, feature request, or comment.

This worked fine when I tested the PR #4001, but now that it's deployed to a couple servers, that option isn't there.

Image

@gabek gabek added bug Something isn't working chat Issues dealing with the web chat client and server labels Nov 11, 2024
@mahmed2000
Copy link
Contributor

7830b37 bruh.

Its the custom category sorting. Its a listed issue in the emoji-mart repo missive/emoji-mart#951. Broke with 5.3 and later so I manually set it to ~5.2.2. Renovate had other plans I guess. Until that is fixed upstream, can either keep the older version or allow the custom categories to be last in the order.

@gabek gabek closed this as completed in b177333 Nov 11, 2024
@gabek
Copy link
Member Author

gabek commented Nov 11, 2024

Fixed by hardcoding it to 5.2.2. Renovate should leave it alone now.

@mahmed2000
Copy link
Contributor

Happened again: 4c7ccdb. Renovate is going to need an ignore rule I think.

@gabek
Copy link
Member Author

gabek commented Nov 12, 2024

I pushed a config change to hopefully force it to do what I expected it to do in the first place.

@gabek
Copy link
Member Author

gabek commented Nov 13, 2024

Nope, that didn't work either. There has to be an option between automatically update without giving anybody a choice, and completely never updating ever again.

@mahmed2000
Copy link
Contributor

mahmed2000 commented Nov 13, 2024

Might just be an invalid regex? The slashes are missing.

This field also supports Regular Expressions which must begin and end with /.

https://docs.renovatebot.com/configuration-options/#matchcurrentversion

Configuration Options usable in renovate.json or package.json

@gabek
Copy link
Member Author

gabek commented Nov 13, 2024

Nice catch, I just pushed a change. Let's see if it helps. If not, I'll just ignore it completely in the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chat Issues dealing with the web chat client and server
Projects
None yet
Development

No branches or pull requests

2 participants