Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for Night Owl Light #17

Open
andybroger opened this issue Aug 9, 2023 · 5 comments
Open

Feature Request: Add support for Night Owl Light #17

andybroger opened this issue Aug 9, 2023 · 5 comments
Labels
feature request This is a request to add a feature not yet implemented impl approach pending in roadmap

Comments

@andybroger
Copy link

andybroger commented Aug 9, 2023

Hello

First, a wonderful implementation of the original theme.
Is there a plan to also implement Night Owl Light?
As i frequently switch between Light/Dark Mode.

@oxfist oxfist added the enhancement New feature or request label Aug 14, 2023
@oxfist
Copy link
Owner

oxfist commented Aug 17, 2023

Hey @andybroger! Thanks so much for your kind words. I didn't have the chance to respond earlier.

So far I don't have the implementation of a light version of the theme in the roadmap. I'm currently working on ensuring support for a few languages that I see as good incentives to increase adoption. Considering past contributions and current number of stars, I think I'm on the right track.

A light version will for sure make this implementation better, but it would require a fair amount of work. I've not delved too much into Lua configurations for this theme and currently have no tests whatsoever as my main priority has been better language support.

If this issue gets more support I would definitely consider it a higher priority. It would also be useful to know which languages you use and would want support for with a light version.

My overall goal is to have a full and excellent implementation of the original theme, because I love it so much, and even go beyond that, considering Sarah has not had updates for the VSCode theme for a while now.

@oxfist oxfist changed the title Night Owl Light Add support for Night Owl Light Aug 17, 2023
@oxfist oxfist added feature request This is a request to add a feature not yet implemented and removed enhancement New feature or request labels Aug 28, 2023
@hiyorijl
Copy link

i'm also in favor of this too please, to add light version; it would be so pretty

@ubmit
Copy link

ubmit commented Mar 10, 2024

i'd love to have the light version 🙌

@oxfist
Copy link
Owner

oxfist commented Jul 4, 2024

Quick update:

Now that the theme can be configured using Lua, I have the base implementation I need to work on something like this:

require('night-owl').setup({
  -- ...
  light_mode = true,
})

I'm currently trying to organize the color palette of the theme based on the original VS Code implementation by Sarah, to which I've added a few tweaks for what I consider better consistency. Once I have that, I'm going to work on getting all the right mappings form dark to light mode, before refactoring the implementation to easily swap the hex values used.

Please leave a thumbs up if you're interested in having this option available! 👍🏼

@oxfist oxfist changed the title Add support for Night Owl Light Feature Request: Add support for Night Owl Light Sep 12, 2024
@luxus
Copy link

luxus commented Sep 22, 2024

the colorscheme is wonderful, looking forward to lightmode. maybe instead of a setup option it would be nice to use the background option of neovim?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request This is a request to add a feature not yet implemented impl approach pending in roadmap
Projects
None yet
Development

No branches or pull requests

5 participants