Skip to content

Firewall rules should allow setting/viewing multiple ICMP filters #2846

Open
@FelixMcFelix

Description

@FelixMcFelix

VpcFirewallRuleProtocols can now carry more information than a protocol alone. Today this is only expressed in ICMP type/code filters, but in future this will include ICMPv6 and probably a generic selector over the IP protocol code. We should allow interaction with a list of filters, rather than the three checkboxes we have today.

https://github.com/oxidecomputer/omicron/blob/d84882702969e42be311f1b4274ab9a4ab9d28a3/openapi/nexus.json#L26196-L26251

The move from representing each as a string to a kind+value will also impact how these are serialised/deserialised.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions