Code modernization via Rubocop (#2308)

* Address Lint/AmbiguousBlockAssociation

* Address Lint/AmbiguousOperator

* Address Lint/AmbiguousRegexpLiteral

* Address Lint/EmptyWhen

* Address Lint/LiteralAsCondition

* Address Lint/MissingSuper

* Address Lint/RedundantRequireStatement

* Address Lint/RedundantSplatExpansion

* Address Lint/RedundantWithObject

* Address Lint/SuppressedException

* Address Lint/UnderscorePrefixedVariableName

* Address Lint/UnusedBlockArgument

* Address Lint/UselessAssignment

* Address Style/AndOr

* Address Style/CommandLiteral

* Address Style/CommentAnnotation

* Address Style/ConditionalAssignment

* Address Style/Dir

* Address Style/DoubleNegation

* Address Style/EachWithObject

* Address Style/EmptyLiteral

* Address Style/EmptyMethod

* Address Style/Encoding

* Address Style/EvalWithLocation

* Address Style/ExpandPathArguments

* Address Style/ExplicitBlockArgument

* Address Style/For

* Address Style/HashAsLastArrayItem

* Address Style/HashEachMethods

* Address Style/HashLikeCase

* Address Style/HashTransformValues

* Address Style/IdenticalConditionalBranches

* Address Style/InverseMethods

* Address Style/LineEndConcatenation

* Address MethodCallWithoutArgsParentheses

* Address Style/MinMax

* Address Style/Next

* Address Style/Not

* Address Style/NumericLiteralPrefix

* Address Style/NumericLiterals

* Address Style/OrAssignment

* Address Style/PercentLiteralDelimiters

* Address Style/Proc

* Address Style/RedundantAssignment

* Address Style/RedundantBegin

* Address Style/RedundantCapitalW

* Address Style/RedundantFreeze

* Address Style/RedundantInterpolation

* Address Style/RedundantParentheses

* Address Style/RedundantRegexpEscape

* Address Style/RedundantReturn

* Address Style/SafeNavigation

* Address Style/SymbolProc

* Address Style/TernaryParentheses

* Address Style/TrailingCommaInArguments

* Address Style/TrailingCommaInArrayLiteral

* Address Style/TrailingUnderscoreVariable

* Address Style/WhileUntilModifier

* Address Style/YodaCondition

* Address Style/StringLiterals

* Address Layout/SpaceBeforeBlockBraces

* Address Layout/SpaceAroundEqualsInParameterDefault

* Address Layout/SpaceAfterComma

* Address Style/HashSyntax directly

* Checkpoint: Update rubocop config

Author: crashtech

.rubocop.yml

@@ -2,93 +2,123 @@ require:
   - rubocop-minitest
 
 AllCops:
-  NewCops: disable
+  TargetRubyVersion: 2.7
+#   DisabledByDefault: true
 
-Metrics:
-  Enabled: false
-Naming:
-  Enabled: false
-Layout:
-  Enabled: false
-Lint/AssignmentInCondition:
-  Enabled: false
-Lint/UnusedMethodArgument:
-  Enabled: false
-Style/AccessorGrouping:
-  Enabled: false
-Style/Alias:
-  Enabled: false
-Style/ArrayJoin:
-  Enabled: false
-Style/BlockDelimiters:
-  Enabled: false
-Style/CharacterLiteral:
-  Enabled: false
-Style/ClassAndModuleChildren:
-  Enabled: false
-Style/ClassCheck:
-  Enabled: false
-Style/ClassVars:
-  Enabled: false
-Style/CommentedKeyword:
-  Enabled: false
-Style/Documentation:
-  Enabled: false
-Style/EmptyCaseCondition:
-  Enabled: false
-Style/FormatString:
-  Enabled: false
-Style/FormatStringToken:
-  Enabled: false
-Style/FrozenStringLiteralComment:
-  Enabled: false
-Style/GuardClause:
-  Enabled: false
-Style/HashSyntax:
-  Enabled: false
-Style/IfInsideElse:
-  Enabled: false
-Style/IfUnlessModifier:
-  Enabled: false
-Style/IfUnlessModifierOfIfUnless:
-  Enabled: false
-Style/MultilineIfModifier:
-  Enabled: false
-Style/MultilineTernaryOperator:
-  Enabled: false
-Style/NestedTernaryOperator:
-  Enabled: false
-Style/MutableConstant:
-  Enabled: false
-Style/NumericPredicate:
-  Enabled: false
-Style/ParallelAssignment:
-  Enabled: false
-Style/PreferredHashMethods:
-  Enabled: false
-Style/RedundantSelf:
-  Enabled: false
-Style/RegexpLiteral:
-  Enabled: false
-Style/Semicolon:
-  Enabled: false
-Style/SignalException:
-  Enabled: false
-Style/SingleLineMethods:
-  Enabled: false
-Style/SoleNestedConditional:
-  Enabled: false
-Style/StringConcatenation:
-  Enabled: false
-Style/StringLiterals:
-  Enabled: false
-Style/StringLiteralsInInterpolation:
-  Enabled: false
-Style/SymbolArray:
-  Enabled: false
-Style/TrailingCommaInHashLiteral:
+# Style/HashSyntax:
+#   Enabled: true
+
+## Custom settings according to the current codebase
+Lint/MissingSuper:
+  AllowedParentClasses:
+    - Rackup::Server
+
+
+## Won't change without breaking changes or major refactoring
+Style/OptionalBooleanParameter:
   Enabled: false
-Style/WordArray:
+
+Style/RescueModifier:
   Enabled: false
-Style/ZeroLengthPredicate:
+
+Style/StderrPuts:
   Enabled: false
+
+
+## It's not really necessary to address about these
+Style/ModuleFunction:
+  Severity: warning
+
+Style/MultipleComparison:
+  Severity: warning
+
+Style/RescueStandardError:
+  Severity: warning
+
+Style/SpecialGlobalVars:
+  Severity: warning
+
+
+## We should address these eventually
+Style/CaseEquality:
+  Exclude:
+    - padrino-core/lib/padrino-core/filter.rb
+    - padrino-core/lib/padrino-core/path_router/compiler.rb
+
+Style/CombinableLoops:
+  Exclude:
+    - padrino-gen/lib/padrino-gen/padrino-tasks/mongoid.rb
+
+Style/Encoding:
+  Exclude:
+    - padrino-admin/padrino-admin.gemspec
+    - padrino-cache/padrino-cache.gemspec
+    - padrino-gen/lib/padrino-gen/generators/project/config.ru
+    - padrino-gen/padrino-gen.gemspec
+    - padrino-helpers/padrino-helpers.gemspec
+    - padrino-mailer/padrino-mailer.gemspec
+    - padrino-performance/padrino-performance.gemspec
+    - padrino-support/padrino-support.gemspec
+    - padrino/padrino.gemspec
+
+Style/EvalWithLocation:
+  Exclude:
+    - padrino-core/lib/padrino-core/cli/base.rb
+
+Lint/SendWithMixinArgument:
+  Exclude:
+    - padrino-performance/lib/suites/json.rb
+
+Lint/ScriptPermission:
+  Exclude:
+    - padrino-admin/padrino-admin.gemspec
+    - padrino-cache/padrino-cache.gemspec
+    - padrino-gen/lib/padrino-gen/generators/project/config.ru
+    - padrino-gen/padrino-gen.gemspec
+    - padrino-helpers/padrino-helpers.gemspec
+    - padrino-mailer/padrino-mailer.gemspec
+    - padrino-performance/padrino-performance.gemspec
+    - padrino-support/padrino-support.gemspec
+    - padrino/padrino.gemspec
+
+Lint/RescueException:
+  Exclude:
+    - padrino-core/lib/padrino-core/application/routing.rb
+    - padrino-core/lib/padrino-core/loader.rb
+    - padrino-core/lib/padrino-core/reloader.rb
+
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - padrino-core/lib/padrino-core/cli/base.rb
+    - padrino-core/lib/padrino-core/cli/launcher.rb
+    - padrino-helpers/lib/padrino-helpers/form_builder/abstract_form_builder.rb
+
+Lint/ShadowedException:
+  Exclude:
+    - padrino-core/lib/padrino-core/cli/binstub.rb
+
+Lint/UselessMethodDefinition:
+  Exclude:
+    - padrino-core/test/fixtures/apps/mountable_apps/rack_apps.rb
+
+
+## Tests exclusions
+Naming/FileName:
+  Exclude:
+    - '**/test/**/*'
+
+Style/GlobalVars:
+  Exclude:
+    - '**/test/**/*'
+
+Lint/RaiseException:
+  Exclude:
+    - '**/test/**/*'
+
+Lint/EmptyFile:
+  Exclude:
+    - '**/test/**/*'
+
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - '**/test/**/*'

Gemfile

@@ -2,65 +2,65 @@ require File.expand_path('padrino-core/lib/padrino-core/version.rb', __dir__)
 
 source 'https://rubygems.org'
 
-if ENV["AS_VERSION"]
+if ENV['AS_VERSION']
   gem 'activesupport', "~> #{ENV['AS_VERSION']}"
 end
 
 group :db do
-  gem "jdbc-sqlite3", "~> 3.7.2", :platform => :jruby
-  gem "sequel"
-  gem "sqlite3", :platforms => [:mri]
+  gem 'jdbc-sqlite3', '~> 3.7.2', platform: :jruby
+  gem 'sequel'
+  gem 'sqlite3', platforms: [:mri]
 end
 
 group :development do
-  if ENV["SINATRA_VERSION"]
+  if ENV['SINATRA_VERSION']
     puts "=> Using Sinatra version ~> #{ENV['SINATRA_VERSION']}"
-    gem "sinatra", "~> #{ENV['SINATRA_VERSION']}"
+    gem 'sinatra', "~> #{ENV['SINATRA_VERSION']}"
   elsif ENV['SINATRA_EDGE']
-    puts "=> Using sinatra edge"
-    gem "sinatra", :git => "git://github.com/sinatra/sinatra.git"
+    puts '=> Using sinatra edge'
+    gem 'sinatra', git: 'git://github.com/sinatra/sinatra.git'
   end
 
-  gem "liquid",    ">= 2.1.1"
-  gem "slim",      ">= 1.3.0"
+  gem 'liquid',    '>= 2.1.1'
+  gem 'slim',      '>= 1.3.0'
 
   if ENV['HAML_ENGINE'] == 'hamlit'
-    puts "=> Using Hamlit Haml engine"
-    gem "hamlit"
+    puts '=> Using Hamlit Haml engine'
+    gem 'hamlit'
   else
-    gem "haml",      "~> 5"
+    gem 'haml',      '~> 5'
   end
 
   case ENV['ERB_ENGINE']
-  when "stdlib"
-    puts "=> Using stdlib ERB engine"
-  when "erubis"
-    puts "=> Using Erubis ERB engine"
-    gem "erubis",    ">= 2.7.0"
+  when 'stdlib'
+    puts '=> Using stdlib ERB engine'
+  when 'erubis'
+    puts '=> Using Erubis ERB engine'
+    gem 'erubis',    '>= 2.7.0'
   else
-    gem "erubi",     ">= 1.6.1"
+    gem 'erubi',     '>= 1.6.1'
   end
 
-  gem "builder",    ">= 2.1.2"
-  gem "minitest", ">= 4.0"
-  gem "mocha",    ">= 2.0"
-  gem "oga",       ">= 2.5", "< 3"
-  gem "rack",      "~> 3"
-  gem "rackup",    "~> 2.1"
-  gem "rack-test", "~> 2.1"
-  gem "rake",      ">= 10.5.0"
+  gem 'builder',    '>= 2.1.2'
+  gem 'minitest', '>= 4.0'
+  gem 'mocha',    '>= 2.0'
+  gem 'oga',       '>= 2.5', '< 3'
+  gem 'rack',      '~> 3'
+  gem 'rackup',    '~> 2.1'
+  gem 'rack-test', '~> 2.1'
+  gem 'rake',      '>= 10.5.0'
   gem 'rb-readline', '~> 0.4.2'
-  gem 'rubocop', '~> 1.6', :platforms => [:mri]
-  gem 'rubocop-minitest', '~>0.34.4', :platforms => [:mri]
-  gem "webmock", "~> 3.19"
-  gem "yard",      ">= 0.7.2"
+  gem 'rubocop', '~> 1.6', platforms: [:mri]
+  gem 'rubocop-minitest', '~>0.34.4', platforms: [:mri]
+  gem 'webmock', '~> 3.19'
+  gem 'yard',      '>= 0.7.2'
 
   platforms :jruby do
-    gem "jruby-openssl"
+    gem 'jruby-openssl'
   end
 end
 
 load File.expand_path('padrino/subgems.rb', __dir__)
 PADRINO_GEMS.each_key do |name|
-  gem name, :path => File.expand_path('../' + name, __FILE__)
+  gem name, path: File.expand_path('../' + name, __FILE__)
 end