Merge next into develop (#7492)

Author: ggdouglas

.circleci/config.yml

@@ -169,7 +169,6 @@ jobs:
             0) yarn nx run-many -t test:typeCheck ;; \
             1) yarn nx test:karma @blueprintjs/core ;; \
             2) yarn nx test:karma @blueprintjs/datetime ;; \
-            3) yarn nx test:karma @blueprintjs/datetime2 ;; \
             4) yarn nx test:karma @blueprintjs/select ;; \
             5) yarn nx test:karma @blueprintjs/table
             esac

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -13,7 +13,7 @@ about: Something not working as expected?
 
 #### Code Sandbox
 
-Link to a minimal repro (fork [this code sandbox](https://codesandbox.io/p/sandbox/blueprint-v5-x-sandbox-react-16-wy0ojy)): <!-- here -->
+Link to a minimal repro (fork [this code sandbox](https://codesandbox.io/p/sandbox/blueprint-v6-react-18-template-lc69nt)): <!-- here -->
 
 #### Steps to reproduce
 

.yarn/patches/react-day-picker-npm-7.4.9-8853eff118.patch

@@ -2,9 +2,9 @@
     "extends": "./tsconfig.base",
     "compilerOptions": {
         "jsx": "react",
-        "lib": ["dom", "dom.iterable", "es5", "es2015.collection", "es2015.iterable"],
+        "lib": ["dom", "dom.iterable", "es2019"],
         "module": "es2020",
         "moduleResolution": "node",
-        "target": "es5"
+        "target": "es2019"
     }
 }

config/tsconfig.web.json

@@ -14,7 +14,6 @@ module.exports = async function (config) {
                 // no need to test legacy APIs
                 "src/legacy/*",
                 "src/common/keyCodes.ts",
-                "src/deprecatedTypeAliases.ts",
 
                 // not worth full coverage
                 "src/accessibility/*",

packages/core/karma.conf.js

@@ -1,15 +1,13 @@
 {
     "name": "@blueprintjs/core",
-    "version": "5.19.1",
+    "version": "6.0.0-alpha.2",
     "description": "Core styles & components",
     "main": "lib/cjs/index.js",
     "module": "lib/esm/index.js",
     "esnext": "lib/esnext/index.js",
     "typings": "lib/esm/index.d.ts",
     "style": "lib/css/blueprint.css",
-    "unpkg": "dist/core.bundle.js",
     "files": [
-        "dist",
         "lib",
         "scripts",
         "src"
@@ -33,7 +31,6 @@
         "compile:css": "sass-compile ./src",
         "dev": "run-p \"compile:esm --watch\" \"compile:css --watch\"",
         "dist": "run-s \"dist:*\"",
-        "dist:bundle": "NODE_ENV=production webpack",
         "dist:css": "css-dist lib/css",
         "dist:variables": "generate-css-variables --retainDefault true ../../colors/src/_colors.scss common/_color-aliases.scss common/_variables.scss",
         "dist:verify": "assert-package-layout",
@@ -56,14 +53,13 @@
         "normalize.css": "^8.0.1",
         "react-popper": "^2.3.0",
         "react-transition-group": "^4.4.5",
-        "react-uid": "^2.3.3",
         "tslib": "~2.6.2",
         "use-sync-external-store": "^1.2.0"
     },
     "peerDependencies": {
-        "@types/react": "^16.14.41 || 17 || 18",
-        "react": "^16.8 || 17 || 18",
-        "react-dom": "^16.8 || 17 || 18"
+        "@types/react": "18",
+        "react": "18",
+        "react-dom": "18"
     },
     "peerDependenciesMeta": {
         "@types/react": {

packages/core/package.json

@@ -16,7 +16,7 @@
 // Namespace appended to the beginning of each CSS class: `.#{$ns}-button`.
 // N.B. No quotes around this string value, for Less syntax compatibility. Also, this cannot be overriden
 // (the JS components have this class prefix hard-coded), so it does not have the `!default` modifier.
-$ns: bp5;
+$ns: bp6;
 // Alias for BP users outside this repo
 $bp-ns: $ns;
 

packages/core/src/common/_variables.scss

@@ -19,14 +19,13 @@ import type { ButtonVariant } from "./buttonVariant";
 import { Elevation } from "./elevation";
 import { Intent } from "./intent";
 import { Position } from "./position";
-import type { HTMLInputProps } from "./props";
 import type { Size } from "./size";
 
 // injected by webpack.DefinePlugin
 declare let BLUEPRINT_NAMESPACE: string | undefined;
 declare let REACT_APP_BLUEPRINT_NAMESPACE: string | undefined;
 
-let NS = "bp5";
+let NS = "bp6";
 
 if (typeof BLUEPRINT_NAMESPACE !== "undefined") {
     NS = BLUEPRINT_NAMESPACE;
@@ -178,8 +177,6 @@ export const ENTITY_TITLE_TITLE_AND_TAGS = `${ENTITY_TITLE}-title-and-tags`;
 export const FLEX_EXPANDER = `${NS}-flex-expander`;
 
 export const HTML_SELECT = `${NS}-html-select`;
-/** @deprecated use `<HTMLSelect>` component or `Classes.HTML_SELECT` instead */
-export const SELECT = `${NS}-select`;
 
 export const HTML_TABLE = `${NS}-html-table`;
 export const HTML_TABLE_BORDERED = `${HTML_TABLE}-bordered`;
@@ -278,15 +275,19 @@ export const OVERLAY_SCROLL_CONTAINER = `${OVERLAY}-scroll-container`;
 export const OVERLAY_START_FOCUS_TRAP = `${OVERLAY}-start-focus-trap`;
 export const OVERLAY_END_FOCUS_TRAP = `${OVERLAY}-end-focus-trap`;
 
-export const PANEL_STACK = `${NS}-panel-stack`;
+export const PANEL_STACK = `${NS}-panel-stack2`;
 export const PANEL_STACK_HEADER = `${PANEL_STACK}-header`;
 export const PANEL_STACK_HEADER_BACK = `${PANEL_STACK}-header-back`;
 export const PANEL_STACK_VIEW = `${PANEL_STACK}-view`;
 
-export const PANEL_STACK2 = `${NS}-panel-stack2`;
-export const PANEL_STACK2_HEADER = `${PANEL_STACK2}-header`;
-export const PANEL_STACK2_HEADER_BACK = `${PANEL_STACK2}-header-back`;
-export const PANEL_STACK2_VIEW = `${PANEL_STACK2}-view`;
+/** @deprecated Use `PANEL_STACK` instead */
+export const PANEL_STACK2 = PANEL_STACK;
+/** @deprecated Use `PANEL_STACK_HEADER` instead */
+export const PANEL_STACK2_HEADER = PANEL_STACK_HEADER;
+/** @deprecated Use PANEL_STACK_HEADER_BACK instead */
+export const PANEL_STACK2_HEADER_BACK = PANEL_STACK_HEADER_BACK;
+/** @deprecated Use PANEL_STACK_VIEW instead */
+export const PANEL_STACK2_VIEW = PANEL_STACK_VIEW;
 
 export const POPOVER = `${NS}-popover`;
 export const POPOVER_ARROW = `${POPOVER}-arrow`;
@@ -449,7 +450,7 @@ export function positionClass(position: Position | undefined) {
 }
 
 export function sizeClass(
-    size: Size | HTMLInputProps["size"],
+    size: Size,
     legacyProps: Partial<Record<"large" | "small", boolean>>,
 ): string | Record<string, boolean> {
     if (size === "small") {

packages/core/src/common/classes.ts

@@ -45,7 +45,7 @@ export const HOTKEYS_PROVIDER_NOT_FOUND =
     ` useHotkeys() was used outside of a <HotkeysProvider> context. These hotkeys will not be shown in the hotkeys help dialog.`;
 export const HOTKEYS_TARGET_CHILDREN_LOCAL_HOTKEYS =
     ns +
-    ` <HotkeysTarget2> was configured with local hotkeys, but you did not use the generated event handlers to bind their event handlers. Try using a render function as the child of this component.`;
+    ` <HotkeysTarget> was configured with local hotkeys, but you did not use the generated event handlers to bind their event handlers. Try using a render function as the child of this component.`;
 
 export const INPUT_WARN_LEFT_ELEMENT_LEFT_ICON_MUTEX =
     ns + ` <InputGroup> leftElement and leftIcon prop are mutually exclusive, with leftElement taking priority.`;
@@ -68,10 +68,6 @@ export const NUMERIC_INPUT_STEP_SIZE_NON_POSITIVE =
 export const NUMERIC_INPUT_CONTROLLED_VALUE_INVALID =
     ns + ` <NumericInput> controlled value prop does not adhere to stepSize, min, and/or max constraints.`;
 
-export const PANEL_STACK_INITIAL_PANEL_STACK_MUTEX =
-    ns + ` <PanelStack> requires exactly one of initialPanel and stack prop`;
-export const PANEL_STACK_REQUIRES_PANEL = ns + ` <PanelStack> requires at least one panel in the stack`;
-
 export const OVERFLOW_LIST_OBSERVE_PARENTS_CHANGED =
     ns + ` <OverflowList> does not support changing observeParents after mounting.`;
 
@@ -88,10 +84,6 @@ export const POPOVER_WARN_UNCONTROLLED_ONINTERACTION = ns + ` <Popover> onIntera
 export const POPOVER_WARN_TARGET_PROPS_WITH_RENDER_TARGET =
     ns + ` <Popover> targetProps value is ignored when renderTarget API is used.`;
 
-export const PORTAL_CONTEXT_CLASS_NAME_STRING = ns + ` <Portal> context blueprintPortalClassName must be string`;
-export const PORTAL_LEGACY_CONTEXT_API =
-    ns + ` setting blueprintPortalClassName via legacy React context API is deprecated, use <PortalProvider> instead.`;
-
 export const RADIOGROUP_WARN_CHILDREN_OPTIONS_MUTEX =
     ns + ` <RadioGroup> children and options prop are mutually exclusive, with options taking priority.`;
 
@@ -111,11 +103,6 @@ export const TOASTER_CREATE_NULL =
     ns +
     ` OverlayToaster.create() is not supported inside React lifecycle methods in React 16.` +
     ` See usage example on the docs site. https://blueprintjs.com/docs/#core/components/toast.example`;
-export const TOASTER_CREATE_ASYNC_NULL =
-    ns +
-    ` OverlayToaster.createAsync() received a null component ref. This can happen if called inside React lifecycle ` +
-    `methods in React 16. See usage example on the docs site. ` +
-    `https://blueprintjs.com/docs/#core/components/toast.example`;
 export const TOASTER_MAX_TOASTS_INVALID =
     ns + ` <OverlayToaster> maxToasts is set to an invalid number, must be greater than 0`;
 export const TOASTER_WARN_INLINE =