You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
5. Ensure your code **compiles properly** and is **tested**, **linted**, and **formatted**.
46
-
- Run `yarn compile` at the repo root to build all libraries.
47
-
- Run `yarn bundle` at the repo root to build the Blueprint documentation and other bundles.
48
-
- Add unit tests as necessary when fixing bugs or adding features; run them with `yarn test` in the relevant package directory.
49
-
- Linting is best handled by your editor for real-time feedback (see [Editor integration](https://github.com/palantir/blueprint/wiki/Editor-integration)). Run `yarn lint` to be 100% safe.
50
-
- TypeScript lint errors can often be automatically fixed by ESLint. Run lint fixes with `yarn lint-fix`.
51
-
- Code formatting is enforced using [Prettier](https://prettier.io/). These errors can be fixed in your editor through the Prettier extension (make sure you have set up the editor integrations linked above). **Formatting checks will not run** during the `yarn lint` package script. Instead, when using the CLI or in a CI environment you should run the `yarn format` script to fix all formatting issues across the Blueprint monorepo.
46
+
- Run `pnpm compile` at the repo root to build all libraries.
47
+
- Run `pnpm bundle` at the repo root to build the Blueprint documentation and other bundles.
48
+
- Add unit tests as necessary when fixing bugs or adding features; run them with `pnpm test` in the relevant package directory.
49
+
- Linting is best handled by your editor for real-time feedback (see [Editor integration](https://github.com/palantir/blueprint/wiki/Editor-integration)). Run `pnpm lint` to be 100% safe.
50
+
- TypeScript lint errors can often be automatically fixed by ESLint. Run lint fixes with `pnpm lint-fix`.
51
+
- Code formatting is enforced using [Prettier](https://prettier.io/). These errors can be fixed in your editor through the Prettier extension (make sure you have set up the editor integrations linked above). **Formatting checks will not run** during the `pnpm lint` package script. Instead, when using the CLI or in a CI environment you should run the `pnpm format` script to fix all formatting issues across the Blueprint monorepo.
52
52
6. Submit a Pull Request on GitHub and fill out the template.
53
53
- ⚠️ **DO NOT enable CircleCI for your fork of Blueprint.** When you open a PR, your branch will be checked out and built in palantir's CI pipeline automatically. There is no need to enable the CI build for your fork's pipeline. If you do, this may cause problems in the CI build.
54
54
- If you have already opened a PR where CircleCI built the code in your own personal or organization pipeline, you will likely have to disable the project from building at app.circleci.com/settings/project/github/\<your-username\>/website and open a new PR.
0 commit comments