[core] fix(MenuItem): make items focusable for a11y consistency (#4892)

adidahiya · web-flow · commit 88a158b38a96 · 2021-09-08T16:18:18.000-04:00
diff --git a/packages/core/src/components/menu/menuItem.tsx b/packages/core/src/components/menu/menuItem.tsx
@@ -161,6 +161,7 @@ export class MenuItem extends AbstractPureComponent2<MenuItemProps & React.Ancho
         const target = React.createElement(
             tagName,
             {
+                tabIndex: 0,
                 ...htmlProps,
                 ...(disabled ? DISABLED_PROPS : {}),
                 className: anchorClasses,

Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,7 @@ export class MenuItem extends AbstractPureComponent2<MenuItemProps & React.Ancho`
`161`	`161`	`const target = React.createElement(`
`162`	`162`	`tagName,`
`163`	`163`	`{`
	`164`	`+ tabIndex: 0,`
`164`	`165`	`...htmlProps,`
`165`	`166`	`...(disabled ? DISABLED_PROPS : {}),`
`166`	`167`	`className: anchorClasses,`