Fix flaky tests in Popover, Overlay2, and Table components (#7596)

Co-authored-by: Gregory Douglas <[email protected]>

Author: MattHandzel

packages/core/test/overlay2/overlay2Tests.tsx

@@ -31,7 +31,7 @@ import {
     Portal,
     Utils,
 } from "../../src";
-import { findInPortal, sleep } from "../utils";
+import { findInPortal } from "../utils";
 
 import "./overlay2-test-debugging.scss";
 
@@ -723,7 +723,13 @@ describe("<Overlay2>", () => {
         assert.isTrue(onOpening.calledOnce, "onOpening");
         assert.isFalse(onOpened.calledOnce, "onOpened not called yet");
 
-        await sleep(10);
+        // Wait for transition to complete and onOpened to be called
+        await waitFor(
+            () => {
+                assert.isTrue(onOpened.calledOnce, "onOpened");
+            },
+            { timeout: 100 },
+        );
 
         // on*ed called after transition completes
         assert.isTrue(onOpened.calledOnce, "onOpened");
@@ -733,9 +739,15 @@ describe("<Overlay2>", () => {
         assert.isTrue(onClosing.calledOnce, "onClosing");
         assert.isFalse(onClosed.calledOnce, "onClosed not called yet");
 
-        await sleep(10);
+        // Wait for transition to complete and onClosed to be called
+        await waitFor(
+            () => {
+                assert.isTrue(onClosed.calledOnce, "onClosed");
+            },
+            { timeout: 100 },
+        );
 
-        assert.isTrue(onClosed.calledOnce, "onOpened");
+        assert.isTrue(onClosed.calledOnce, "onClosed");
     });
 
     let index = 0;

packages/core/test/popover/popoverTests.tsx

@@ -345,7 +345,7 @@ describe("<Popover>", () => {
             );
             const targetButton = screen.getByRole("button", { name: "target" });
 
-            userEvent.click(targetButton);
+            await userEvent.click(targetButton);
 
             const overlay = container.querySelector(`.${Classes.OVERLAY}`);
 
@@ -357,7 +357,7 @@ describe("<Popover>", () => {
 
             const closeButton = screen.getByRole("button", { name: "close" });
 
-            userEvent.click(closeButton);
+            await userEvent.click(closeButton);
 
             await waitFor(() => {
                 expect(hasClass(overlay!, Classes.OVERLAY_OPEN)).to.be.false;

packages/table/test/quadrants/tableQuadrantStackTests.tsx

@@ -16,6 +16,7 @@
 
 import { expect } from "chai";
 import { mount } from "enzyme";
+import { act } from "react";
 import * as TestUtils from "react-dom/test-utils";
 import sinon from "sinon";
 
@@ -577,7 +578,9 @@ describe("TableQuadrantStack", () => {
             });
 
             it("invokes onScroll on TOP quadrant wheel", () => {
-                TestUtils.Simulate.wheel(topScrollContainer);
+                act(() => {
+                    TestUtils.Simulate.wheel(topScrollContainer);
+                });
                 expect(onScroll.calledOnce).to.be.true;
             });