[Button] Allow Icons with intent to be displayed inside default Buttons (#7549)

ggdouglas · web-flow · commit df5ba2a5c0fd · 2025-08-21T11:59:59.000-04:00
diff --git a/packages/core/src/components/button/_button.scss b/packages/core/src/components/button/_button.scss
@@ -90,13 +90,15 @@
   }
 
   #{$icon-classes} {
-    color: $pt-icon-color;
-
     &.#{$ns}-align-right {
       margin-left: $button-icon-spacing;
     }
   }
 
+  .#{$ns}-icon:not([class*="#{$ns}-intent-"]) {
+    color: $pt-icon-color;
+  }
+
   // button with SVG icon only (no text or children)
   .#{$ns}-icon:first-child:last-child,
   // if loading, then it contains exactly [spinner, icon]

Original file line number	Diff line number	Diff line change
`@@ -90,13 +90,15 @@`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`#{$icon-classes} {`
`93`		`- color: $pt-icon-color;`
`94`		`-`
`95`	`93`	`&.#{$ns}-align-right {`
`96`	`94`	`margin-left: $button-icon-spacing;`
`97`	`95`	`}`
`98`	`96`	`}`
`99`	`97`
	`98`	`+ .#{$ns}-icon:not([class*="#{$ns}-intent-"]) {`
	`99`	`+ color: $pt-icon-color;`
	`100`	`+ }`
	`101`	`+`
`100`	`102`	`// button with SVG icon only (no text or children)`
`101`	`103`	`.#{$ns}-icon:first-child:last-child,`
`102`	`104`	`// if loading, then it contains exactly [spinner, icon]`