Add isComposing check to EditableText toggleEdit (#7021)

natsuozawa · Natsu Ozawa · web-flow · commit ee26faf0ad8f · 2024-10-23T13:34:46.000+09:00
Co-authored-by: Natsu Ozawa &lt;nozawa@palantir.com&gt;
diff --git a/packages/core/src/components/editable-text/editableText.tsx b/packages/core/src/components/editable-text/editableText.tsx
@@ -357,7 +357,7 @@ export class EditableText extends AbstractPureComponent<EditableTextProps, Edita
         }
 
         const hasModifierKey = altKey || ctrlKey || metaKey || shiftKey;
-        if (event.key === "Enter") {
+        if (event.key === "Enter" && !event.nativeEvent.isComposing) {
             // prevent browsers (Edge?) from full screening with alt + enter
             // shift + enter adds a newline by default
             if (altKey || shiftKey) {

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ export class EditableText extends AbstractPureComponent<EditableTextProps, Edita`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`const hasModifierKey = altKey \|\| ctrlKey \|\| metaKey \|\| shiftKey;`
`360`		`- if (event.key === "Enter") {`
	`360`	`+ if (event.key === "Enter" && !event.nativeEvent.isComposing) {`
`361`	`361`	`// prevent browsers (Edge?) from full screening with alt + enter`
`362`	`362`	`// shift + enter adds a newline by default`
`363`	`363`	`if (altKey \|\| shiftKey) {`